-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process disk rw #287
Merged
Merged
Process disk rw #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Great to see this get added! |
GuillaumeGomez
force-pushed
the
process_disk_rw
branch
from
April 6, 2020 14:09
9c01d74
to
299fba6
Compare
GuillaumeGomez
force-pushed
the
process_disk_rw
branch
8 times, most recently
from
April 7, 2020 12:45
9dd8e3a
to
58c00c4
Compare
GuillaumeGomez
force-pushed
the
process_disk_rw
branch
from
April 7, 2020 14:15
58c00c4
to
bf16c48
Compare
GuillaumeGomez
force-pushed
the
process_disk_rw
branch
from
April 7, 2020 20:35
137cd5f
to
0f0ed78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking over #248.
cc @bvaisvi
On windows, the performance are still miserable. An alternative could be to use
GetProcessIoCounters
, however it returns all I/O (so disk+network+driver, whatever "driver" means). So to get a somewhat accurate information, it'd require to get the network usage for the process and subtract it from whatGetProcessIoCounters
returns. Quite annoying... As a result, windows performance is getting 3 times worst when adding new process:The only way I found to reduce this performance drop even more is to only compute disk usage when user requests it (otherwise, it's 70 times slower!!!).