Merge pull request #23 from hawkeye64/master

Fixing for loop. Adding node_modules to .gitignore.
GuilhermeC18 · Mar 25, 2018 · 5cb9947 · 5cb9947
2 parents 3dbaf5d + ed3754f
commit 5cb9947
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.gitignore b/.gitignore
@@ -46,4 +46,5 @@ Network Trash Folder
 Temporary Items
 .apdisk
 
-test
+test
+node_modules
diff --git a/lib/modules/service-device.js b/lib/modules/service-device.js
@@ -497,7 +497,7 @@ OnvifServiceDevice.prototype.setDNS = function(params, callback) {
 				reject(new Error('The "SearchDomain" property was invalid: ' + err_msg));
 				return;
 			}
-			for(let i=0; i<params['SearchDomain']; i++) {
+			for(let i=0; i<params['SearchDomain'].length; i++) {
 				if(err_msg = mOnvifSoap.isInvalidValue(params['SearchDomain'][i], 'string')) {
 					reject(new Error('The "SearchDomain" property was invalid: ' + err_msg));
 					return;