Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/line growht chart #38

Merged
merged 17 commits into from
Nov 4, 2020
Merged

Feature/line growht chart #38

merged 17 commits into from
Nov 4, 2020

Conversation

AntonioNtV
Copy link
Collaborator

Qual o objetivo dessa Pull Request?

Modificar o componente de SimpleLineChart para adequar ao uso de multiplas linhas e criação do SimpleBarChart Component para utilização de grafico de barras.
Adição do graficos de ganho e perdas de linhas
Adição da rota que retorna linhas ganhandas e linhas perdidas para um único estudante

Capturas de tela

https://pasteboard.co/JyPvlk9.png

@AntonioNtV AntonioNtV requested a review from davigps November 4, 2020 17:22
frontend/src/components/SimpleBarChart/index.tsx Outdated Show resolved Hide resolved
frontend/src/components/SimpleBarChart/index.tsx Outdated Show resolved Hide resolved
frontend/src/components/SimpleLineChart/index.tsx Outdated Show resolved Hide resolved
@davigps
Copy link
Member

davigps commented Nov 4, 2020

Agora que tem dois gráficos, eu acho que ficaria legal, se o componente SingleGraph do Profile/styles.ts, tivesse apenas margin-top de 100px e o ListsWrapper tivesse um margin-top de 100px, aí todos os espaçamentos ficariam iguais, o que acha?

@AntonioNtV
Copy link
Collaborator Author

Agora que tem dois gráficos, eu acho que ficaria legal, se o componente SingleGraph do Profile/styles.ts, tivesse apenas margin-top de 100px e o ListsWrapper tivesse um margin-top de 100px, aí todos os espaçamentos ficariam iguais, o que acha?

Vou dar uma olhada nisso.

@davigps davigps merged commit 22c187a into development Nov 4, 2020
@davigps davigps deleted the feature/lineGrowhtChart branch November 4, 2020 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants