prompt_on_close_tab option #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terminals. Values are "never", "with process running", and "always". Additionally, if set to "with process running", the quit-prompt will be shown when quitting Guake if there are any subprocesses running. If set to "always", it essentially overrides the prompt_on_quit option.
|
Look great ! I test it and merge it asap |
|
Tested and approuved ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A feature I was missing from gnome-terminal. Like prompt_on_quit, but for individual terminals. Values are "never" (default), "with process running", and "always".
Additionally, if set to "with process running", the quit-prompt will be shown
when quitting Guake if there are any subprocesses running. If set to "always",
it essentially overrides the prompt_on_quit option.
The option is in the GUI as a dropdown, just above prompt_on_quit. prompt_on_quit now behaves more a sub-option of prompt_on_close_tab.
If one of the two prompts is open (close tab or quit Guake) and the other opens, the first will be destroyed. Otherwise I found Guake wouldn't quit until the close-tab prompt was dismissed.
I changed the prompt text slightly; it includes the number of tabs open when quitting.
Please let me know what you think if you get a chance :)