Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Add support for tabs in keyboard shortcuts #1902

Merged
merged 1 commit into from
Sep 16, 2021
Merged

feat:Add support for tabs in keyboard shortcuts #1902

merged 1 commit into from
Sep 16, 2021

Conversation

Davidy22
Copy link
Collaborator

Also changed the default keybinding for next/prev tab. Had to rewrite half of the keybindings code to make this work, but the incidental refactor along the way was pretty good too.

Resolves #152

The keybinding rewrite is hefty, testing before merging preferred, I'll keep using it for now, haven't noticed anything off between finishing the code and creating this pr.

@Davidy22 Davidy22 requested a review from mlouielu September 15, 2021 11:26
Also changed the default keybinding for next/prev tab. Had to rewrite half of the keybindings code to make this work, but the incidental refactor along the way was pretty good too.
@Davidy22 Davidy22 changed the title Add support for tabs in keyboard shortcuts feat:Add support for tabs in keyboard shortcuts Sep 15, 2021
@gsemet gsemet merged commit 6af0a95 into Guake:master Sep 16, 2021
@besworks
Copy link

besworks commented Oct 22, 2021

I just updated my guake install (previous version was only from back around July) and I think something about this PR may have broken my customized keyboard shortcuts which use the super key. Every time I try one the letter I pressed just gets output to the terminal. Other shortcuts I have which do not use the super key still work, and remapping the broken ones also works. Is it just me or can anybody reproduce this behavior?

Update: Apparently if I have an additional modifier like alt or shift then the shortcut works but just super+key doesn't.

@Davidy22
Copy link
Collaborator Author

#1941 has been created to fix this, and I'll create a new release once it gets merged. Can't approve and merge my own pull requests, so waiting on @mlouielu to approve or for @gsemet to release more privileges to us.

@besworks
Copy link

besworks commented Oct 22, 2021

Oh! Great! Thanks for letting me know. I didn't see that when I searched. I will wait for your fix.

Also, thank you for implementing Tab key support in the shortcuts. It's very nice to be able to Ctrl(+Shift)+Tab like in most other apps. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Ctrl-Tab as an accelerator
3 participants