Metadata simplify #1883
Merged
Metadata simplify #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setuptools natively supports declarative setup.cfg for a long time now, so there's no need to specify this in pbr when it can be done in a more stock manner
Use of pbr at runtime is super ugly, as all it does is use pkg_resources to parse distribution versions and pkg_resources could do the exact same thing. But they are both slow, because pkg_resources is (by design) slow. importlib.metadata was added to the stdlib in python 3.8 to fulfill this use case in a speedy and elegant manner. FIXME: this entire schema is ugly, not merely at runtime -- use of pbr for versioning from git is an outdated and stale idea, this should use setuptools_scm instead which: - is standard - supports writing the version to _version.py
Do not rely on running pip to install dependencies, which e.g. distros cannot do. Instead let this be specified directly as package metadata. While we are at it, stop actually running pip install if DESTDIR is set, since this is a fairly likely sign that guake is being installed in a distro environment where pip install is not allowed.
Davidy22
approved these changes
Sep 9, 2021
There was a problem hiding this comment.
Builds and runs fine, did some searching to make sure that cutting /data from here would have no side effects and grep doesn't turn up relevant references and the wheel looks fine too. The other changes look like updates to equivalent actions and ci still works, so I'll merge.
|
Double checking history it seems that the data directory got deleted/moved in 4153ef3 at which point the data_files glob got forgotten. |
|
At this point there is very little pbr still in use, so I am hopeful I will be able to get a modern and clean pure setup.cfg setup in the near future... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use more idiomatic setup.cfg where possible, preferring setuptools built-in features where possible instead of pbr-specific ones.