Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revive GUAKE_TAB_UUID #1855

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Revive GUAKE_TAB_UUID #1855

merged 1 commit into from
Sep 8, 2021

Conversation

fx-kirin
Copy link
Contributor

Fixing #1712

Davidy22
Davidy22 requested changes Sep 8, 2021
View reviewed changes
Copy link
Collaborator

@Davidy22 Davidy22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, does what it's supposed to do, could you just fill in a quick release notes file as well, running:

make reno SLUG=revive_GUAKE_TAB_UUID

And filling out the generated file. You can delete irrelevant sections, I'll merge once you get that filled out.

@Davidy22
Copy link
Collaborator

Davidy22 commented Sep 8, 2021

Filled out the slug file myself.

@Davidy22 Davidy22 merged commit cf705ff into Guake:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Davidy22 Davidy22 Davidy22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fx-kirin @Davidy22