Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1761 guake follows mouse focus when have 2 monitors #1775

Merged
merged 3 commits into from
May 14, 2021

Conversation

woodpenker
Copy link
Contributor

Fix #1761 When Appear on mouse display open for Version 3.7.0 on a dual-screen desktop, the Guake window moves to the other screen if lost focus. This pr is to avoid this annoying situation.

jidar
jidar previously approved these changes Jul 1, 2020
@jidar
Copy link

jidar commented Jul 1, 2020

I have confirmed that this fixes the stated problem.

@borian
Copy link

borian commented Aug 6, 2020

Thanks for the PR. This fixed the Problem.

It can be manually fixed in /lib/python3.8/site-packages/guake/utils.py until this is merged.This bug has been really annoying

@simonmarwitz
Copy link

The manual fix works. However fails, when guake is in the background and other windows are open. Once the last other window is minimized, the terminal switches to the mouse display. This is different than the previous behavior. I tried to find a solution but could not come up with a way to differentiate the two cases, where the terminal gets focus actively (by hotkey) or passively (simply by closing/minimizing all remaining windows).

@woodpenker
Copy link
Contributor Author

The manual fix works. However fails, when guake is in the background and other windows are open. Once the last other window is minimized, the terminal switches to the mouse display. This is different than the previous behavior. I tried to find a solution but could not come up with a way to differentiate the two cases, where the terminal gets focus actively (by hotkey) or passively (simply by closing/minimizing all remaining windows).

Thanks for your feed back. I reproduced your situation and find a way may fix this: Only do unfullscreen when guake is hidden. I test it on my desktop, it seems works well now.

@cybik
Copy link

cybik commented Oct 6, 2020

Raising this PR from the depths. It seems to fix the following glitch here as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

guake follows mouse focus when have 2 monitors
6 participants