Fix make install

[aichingm]

Fix make install.

running install_scripts
Installing guake script to /home/***/guake_pkg/official/pkg/guake-gtk3-git/usr/bin
Error opening directory “/home/***/guake_pkg/official/pkg/guake-gtk3-git/usr//lib/python3.6/dist-packages/guake/data/”: No such file or directory
make: *** [Makefile:42: install-system] Error 1

Shouldn't it be site-packages and not dist-packages?

Should I run make reno SLUG=<short_name_of_my_feature> for this?

[gsemet]

hum make install is more an "example" on how to install on /usr/local, how could it use /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr//lib/python3.6/dist-packages/guake/data/ ?

On my ubuntu 17.04 (python 3.5) and 17.10 (python 3.6), python3 setup.py install actually installs guake in:

/usr/local/lib/python3.6/dist-packages/guake/

Why is it better to use site-packages?

[aichingm]

I'm packaging guake for archlinux with make install-system INSTALL_ROOT="$pkgdir/" PREFIX="$pkgdir/usr/" the alternative path is used so one does not have to build a package as root. Where $pkgdir basically is $(pwd).

The output of make install-system INSTALL_ROOT="$pkgdir/" PREFIX="$pkgdir/usr/"

...
running install_lib
creating /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib
creating /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6
creating /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages
creating /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake
copying build/lib/guake/guake_logging.py -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake
copying build/lib/guake/__init__.py -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake
copying build/lib/guake/terminal.py -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake
copying build/lib/guake/keybindings.py -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake
copying build/lib/guake/utils.py -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake
copying build/lib/guake/common.py -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake
copying build/lib/guake/globals.py -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake
copying build/lib/guake/about.py -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake
creating /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/data
copying build/lib/guake/data/guake.template.desktop -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/data
copying build/lib/guake/data/__init__.py -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/data
copying build/lib/guake/data/about.glade -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/data
creating /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/data/pixmaps
copying build/lib/guake/data/pixmaps/guake-notification.png -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/data/pixmaps
copying build/lib/guake/data/pixmaps/add_tab.png -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/data/pixmaps
copying build/lib/guake/data/pixmaps/guake-tray.svg -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/data/pixmaps
copying build/lib/guake/data/pixmaps/guake.png -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/data/pixmaps
copying build/lib/guake/data/pixmaps/Makefile.am -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/data/pixmaps
copying build/lib/guake/data/pixmaps/quick-open.png -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/data/pixmaps
copying build/lib/guake/data/pixmaps/guake-tray.png -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/data/pixmaps
copying build/lib/guake/data/org.guake.gschema.xml -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/data
copying build/lib/guake/data/guake.glade -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/data
copying build/lib/guake/data/guake-prefs.template.desktop -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/data
copying build/lib/guake/data/prefs.glade -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/data
creating /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/tests
copying build/lib/guake/tests/test_guake.py -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/tests
copying build/lib/guake/prefs.py -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake
copying build/lib/guake/guake_app.py -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake
copying build/lib/guake/settings.py -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake
copying build/lib/guake/simplegladeapp.py -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake
copying build/lib/guake/main.py -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake
copying build/lib/guake/notifier.py -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake
copying build/lib/guake/gsettings.py -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake
copying build/lib/guake/dbusiface.py -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake
copying build/lib/guake/palettes.py -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake
copying build/lib/guake/guake_notebook.py -> /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake
byte-compiling /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/guake_logging.py to guake_logging.cpython-36.pyc
byte-compiling /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/__init__.py to __init__.cpython-36.pyc
byte-compiling /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/terminal.py to terminal.cpython-36.pyc
byte-compiling /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/keybindings.py to keybindings.cpython-36.pyc
byte-compiling /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/utils.py to utils.cpython-36.pyc
byte-compiling /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/common.py to common.cpython-36.pyc
byte-compiling /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/globals.py to globals.cpython-36.pyc
byte-compiling /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/about.py to about.cpython-36.pyc
byte-compiling /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/data/__init__.py to __init__.cpython-36.pyc
byte-compiling /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/tests/test_guake.py to test_guake.cpython-36.pyc
byte-compiling /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/prefs.py to prefs.cpython-36.pyc
byte-compiling /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/guake_app.py to guake_app.cpython-36.pyc
byte-compiling /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/settings.py to settings.cpython-36.pyc
byte-compiling /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/simplegladeapp.py to simplegladeapp.cpython-36.pyc
byte-compiling /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/main.py to main.cpython-36.pyc
byte-compiling /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/notifier.py to notifier.cpython-36.pyc
byte-compiling /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/gsettings.py to gsettings.cpython-36.pyc
byte-compiling /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/dbusiface.py to dbusiface.cpython-36.pyc
byte-compiling /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/palettes.py to palettes.cpython-36.pyc
byte-compiling /home/mario/programming/guake_pkg/official/pkg/guake-gtk3-git/usr/lib/python3.6/site-packages/guake/guake_notebook.py to guake_notebook.cpython-36.pyc
...

shows that dist-packages is not created.

sudo make install gives me the same error and tries to install guake into /usr/lib/python3.6/site-packages/guake but no dist-packages directory is ever created...

sudo make install output:

...
running install_lib
copying build/lib/guake/guake_logging.py -> /usr/lib/python3.6/site-packages/guake
copying build/lib/guake/__init__.py -> /usr/lib/python3.6/site-packages/guake
copying build/lib/guake/terminal.py -> /usr/lib/python3.6/site-packages/guake
copying build/lib/guake/keybindings.py -> /usr/lib/python3.6/site-packages/guake
copying build/lib/guake/utils.py -> /usr/lib/python3.6/site-packages/guake
copying build/lib/guake/common.py -> /usr/lib/python3.6/site-packages/guake
copying build/lib/guake/globals.py -> /usr/lib/python3.6/site-packages/guake
copying build/lib/guake/about.py -> /usr/lib/python3.6/site-packages/guake
copying build/lib/guake/data/guake.template.desktop -> /usr/lib/python3.6/site-packages/guake/data
copying build/lib/guake/data/about.glade -> /usr/lib/python3.6/site-packages/guake/data
copying build/lib/guake/data/org.guake.gschema.xml -> /usr/lib/python3.6/site-packages/guake/data
copying build/lib/guake/data/guake.glade -> /usr/lib/python3.6/site-packages/guake/data
copying build/lib/guake/data/guake.desktop -> /usr/lib/python3.6/site-packages/guake/data
copying build/lib/guake/data/guake-prefs.template.desktop -> /usr/lib/python3.6/site-packages/guake/data
copying build/lib/guake/data/prefs.glade -> /usr/lib/python3.6/site-packages/guake/data
copying build/lib/guake/tests/test_guake.py -> /usr/lib/python3.6/site-packages/guake/tests
copying build/lib/guake/prefs.py -> /usr/lib/python3.6/site-packages/guake
copying build/lib/guake/guake_app.py -> /usr/lib/python3.6/site-packages/guake
copying build/lib/guake/settings.py -> /usr/lib/python3.6/site-packages/guake
copying build/lib/guake/simplegladeapp.py -> /usr/lib/python3.6/site-packages/guake
copying build/lib/guake/main.py -> /usr/lib/python3.6/site-packages/guake
copying build/lib/guake/notifier.py -> /usr/lib/python3.6/site-packages/guake
copying build/lib/guake/gsettings.py -> /usr/lib/python3.6/site-packages/guake
copying build/lib/guake/dbusiface.py -> /usr/lib/python3.6/site-packages/guake
copying build/lib/guake/guake_notebook.py -> /usr/lib/python3.6/site-packages/guake
byte-compiling /usr/lib/python3.6/site-packages/guake/guake_logging.py to guake_logging.cpython-36.pyc
byte-compiling /usr/lib/python3.6/site-packages/guake/__init__.py to __init__.cpython-36.pyc
byte-compiling /usr/lib/python3.6/site-packages/guake/terminal.py to terminal.cpython-36.pyc
byte-compiling /usr/lib/python3.6/site-packages/guake/keybindings.py to keybindings.cpython-36.pyc
byte-compiling /usr/lib/python3.6/site-packages/guake/utils.py to utils.cpython-36.pyc
byte-compiling /usr/lib/python3.6/site-packages/guake/common.py to common.cpython-36.pyc
byte-compiling /usr/lib/python3.6/site-packages/guake/globals.py to globals.cpython-36.pyc
byte-compiling /usr/lib/python3.6/site-packages/guake/about.py to about.cpython-36.pyc
byte-compiling /usr/lib/python3.6/site-packages/guake/tests/test_guake.py to test_guake.cpython-36.pyc
byte-compiling /usr/lib/python3.6/site-packages/guake/prefs.py to prefs.cpython-36.pyc
byte-compiling /usr/lib/python3.6/site-packages/guake/guake_app.py to guake_app.cpython-36.pyc
byte-compiling /usr/lib/python3.6/site-packages/guake/settings.py to settings.cpython-36.pyc
byte-compiling /usr/lib/python3.6/site-packages/guake/simplegladeapp.py to simplegladeapp.cpython-36.pyc
byte-compiling /usr/lib/python3.6/site-packages/guake/main.py to main.cpython-36.pyc
byte-compiling /usr/lib/python3.6/site-packages/guake/notifier.py to notifier.cpython-36.pyc
byte-compiling /usr/lib/python3.6/site-packages/guake/gsettings.py to gsettings.cpython-36.pyc
byte-compiling /usr/lib/python3.6/site-packages/guake/dbusiface.py to dbusiface.cpython-36.pyc
byte-compiling /usr/lib/python3.6/site-packages/guake/guake_notebook.py to guake_notebook.cpython-36.pyc
writing byte-compilation script '/tmp/tmpg08ru4l9.py'
/usr/bin/python3 /tmp/tmpg08ru4l9.py
removing /tmp/tmpg08ru4l9.py
running install_egg_info
Copying Guake.egg-info to /usr/lib/python3.6/site-packages/Guake-3.0.3.dev13-py3.6.egg-info
running install_scripts
Installing guake script to /usr/bin
Error opening directory “/usr/local/lib/python3.6/dist-packages/guake/data/”: No such file or directory
make: *** [Makefile:42: install-system] Error 1

[aichingm]

sudo python setup.py install also installs guake into /usr/lib/python3.6/site-packages/guake on my system.
Python 3.6.4

[gsemet]

ok. apparently this is a debian specificity: https://stackoverflow.com/questions/9387928/whats-the-difference-between-dist-packages-and-site-packages

can you add an top level option such as:

DIST_PACKAGE:=site-packages  # use 'dist-packages' on debian/ubuntu systems

the best would be to find a way to retrieve it from pip. Somes did use something like

python -c "import site; print(site.getsitepackages())"

to get it

[gsemet]

unfortunately pip and easy_install does not install here on debian/ubuntu, so the settings files cannot be compiled here

[aichingm]

Does this work for you?

[gsemet]

looks good :)