-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add (more) colour schemes #273
Comments
Can be easilly done. I m on it |
Not enough time to work on this matter. I'm open to PL. |
So one has to add the palettes here. But what else to mind? Order of palettes (because of translation)? And where can i find infos about the colours? Btw: Would great if a mouseover on the buttons would reveal what button/field colours which part of the terminals. |
I agree, but I don't have time for this. Feel free to try yourself, Python is really simple! |
I would like to try but can't find an explaination about the colour fields. Is there doc about it or do i have to guess? |
I dont have any idea unfortunately. If you find out, could you write it down in a file in the source code? |
I use the following script to inject a monokai palette to guake:
I'm not entirely sure where those values are stored in the source so I can't add a new Palette but I'm certain it would be pretty easy to do so if you have them. Also if you could provide a guide on how to add more palettes, I could easily search for color combinations that people like (like solarized, tomorrow etc) and send a PR |
Palettes are in src/guake/prefs.py, they are ordered the same than in data/pref.glade (palette_name combobox) (search "solarized" occurences in the code)) |
@stibbons I've sent 3 more color palettes PRs and I'm preparing more (if you are willing to accept them), what I wanted to ask though is if there is a way to set the foreground and background colors because most color palettes will look ugly without their proper ones. |
I've ported all the iterm2 color schemes to ones compatible with guake: https://github.com/varemenos/guake-color-palettes let me know if you are interested in integrating them in guake. |
Of course it would be interesting. However it will be quite hard for the user. I propose the following mutual work:
Of course, we can split the making of these screenshots in half so I can help you if you want. |
There is one thing I'd like you to consider before continuing though. The current guake palettes don't set the foreground and background color of the terminal which makes most of them look "ugly" (since the colors don't fit). Would you consider adding those 2 color values to the palette settings as well? Here is an example of what values are set by the scripts. |
ok, i see why you override /apps/guake/style/[font/background]/color. Ok, let me think on how to deal this this in an elegant fashion :) |
Cool, just let me know when to start working on this |
I think it will be pretty simple:
Ex: tango
=> 16 parts tango_forced
=> 18 parts :) I cannot work on this for the moment, but you can start doing screenshots (400x400 would be enough) |
I don't know. Do it has sense to let the user change the color and background color on the palette? |
I think that the front and background colors should be changed only in custom themes, doesn't that make more sense? Or if the user tries to change any color the palette setting should switch from a named palette to "custom". I will start working on those 400x400 screenshots now |
let's have palette with 18 parts. 17th is background and 18th is foreground (font) colors |
Could you please check this branch I've forked from master? I've gone ahead and fixed the old color palettes and loaded all the new ones I've ported from that iterm2 color schemes repository. I wrote a node CLI that takes everything from that repository and prepares the I will take care of the screenshots later, I'm out of willpower 🍕 |
look good. i ve uploaded a version with foreground background readable from palette string. i let you sync with master... for the screenshots, it should be really small actually, 150x150 only. |
anyway, thank you very much for your work :) feel free to add yourself in the contribution file and in the about dialog |
let's forget about screenshot, l'll manage it differently. For me, you can Also, is it possible for you to add tooltip with the meaning on each button Gaetan 2015-04-12 9:01 GMT+02:00 Adonis K. [email protected]:
|
Well, I'm not familiar with python but I will give it a try. I got the diffs from your commits so it will most probably be an easy job. Now I gotta figure out which colors does what :P |
Just edit prefs.glade or use glade2 to edit it Gaetan 2015-04-12 11:42 GMT+02:00 Adonis K. [email protected]:
|
I've tried searching descriptions for the palette but all I've found are vague descriptions like "Palette color 1", "Palette color 2" etc... I will try searching a bit more and If I don't find anything better I will just leave them without labels for now |
no pbl |
This fix: Guake#504, Guake#273, Guake#220 Signed-off-by: Gaetan Semet <[email protected]>
This fix: #504, #273, #220 Signed-off-by: Gaetan Semet <[email protected]>
This fix: #504, #273, #220 Signed-off-by: Gaetan Semet <[email protected]>
The XFCE Terminal has some nice colour scheme presets, it would be great if Guake could profit from that.
The colour schemes there are now look a bit old (IMHO).
It would also make easy for XFCE User to match the schemes of XFCE-Terminal and Guake, without installing or configuring.
Here their presets:
http://git.xfce.org/apps/xfce4-terminal/tree/colorschemes
Edit: I guess Guake uses the GtkSourceView XML files. Is there an upstream or does every application ship what they need?
The text was updated successfully, but these errors were encountered: