Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (more) colour schemes #273

Closed
lightonflux opened this issue Mar 4, 2014 · 27 comments
Closed

Add (more) colour schemes #273

lightonflux opened this issue Mar 4, 2014 · 27 comments

Comments

@lightonflux
Copy link

The XFCE Terminal has some nice colour scheme presets, it would be great if Guake could profit from that.

The colour schemes there are now look a bit old (IMHO).
It would also make easy for XFCE User to match the schemes of XFCE-Terminal and Guake, without installing or configuring.

Here their presets:

http://git.xfce.org/apps/xfce4-terminal/tree/colorschemes

Edit: I guess Guake uses the GtkSourceView XML files. Is there an upstream or does every application ship what they need?

@gsemet gsemet added this to the 0.5.0 milestone Mar 4, 2014
@gsemet gsemet self-assigned this Mar 4, 2014
@gsemet
Copy link
Member

gsemet commented Mar 4, 2014

Can be easilly done. I m on it

@gsemet
Copy link
Member

gsemet commented Mar 17, 2014

Not enough time to work on this matter. I'm open to PL.

@gsemet gsemet modified the milestones: 0.7.0, 0.5.0 Mar 17, 2014
@gsemet gsemet removed their assignment Mar 17, 2014
@lightonflux
Copy link
Author

So one has to add the palettes here. But what else to mind? Order of palettes (because of translation)?

And where can i find infos about the colours? Btw: Would great if a mouseover on the buttons would reveal what button/field colours which part of the terminals.

@gsemet
Copy link
Member

gsemet commented Mar 17, 2014

I agree, but I don't have time for this. Feel free to try yourself, Python is really simple!

@lightonflux
Copy link
Author

I would like to try but can't find an explaination about the colour fields. Is there doc about it or do i have to guess?

@gsemet
Copy link
Member

gsemet commented Mar 22, 2014

I dont have any idea unfortunately. If you find out, could you write it down in a file in the source code?

@varemenos
Copy link
Contributor

I use the following script to inject a monokai palette to guake:

COLORS="#1C1C1D1D1919:#D0D01B1B2424:#A7A7D3D32C2C:#D8D8CFCF6767:#6161B8B8D0D0:#69695A5ABBBB:#D5D538386464:#fefefffffefe:#1C1C1D1D1919:#D0D01B1B2424:#A7A7D3D32C2C:#D8D8CFCF6767:#6161B8B8D0D0:#69695A5ABBBB:#D5D538386464:#fefefffffefe"
FOREGROUND="#F6F6F5F5EEEE"
BACKGROUND="#232325252626"

gconftool-2 -s -t string /apps/guake/style/background/color $BACKGROUND
gconftool-2 -s -t string /apps/guake/style/font/palette $COLORS
gconftool-2 -s -t string /apps/guake/style/font/color $FOREGROUND

I'm not entirely sure where those values are stored in the source so I can't add a new Palette but I'm certain it would be pretty easy to do so if you have them. Also if you could provide a guide on how to add more palettes, I could easily search for color combinations that people like (like solarized, tomorrow etc) and send a PR

@gsemet
Copy link
Member

gsemet commented Feb 22, 2015

Palettes are in src/guake/prefs.py, they are ordered the same than in data/pref.glade (palette_name combobox) (search "solarized" occurences in the code))

@varemenos
Copy link
Contributor

@stibbons I've sent 3 more color palettes PRs and I'm preparing more (if you are willing to accept them), what I wanted to ask though is if there is a way to set the foreground and background colors because most color palettes will look ugly without their proper ones.

@varemenos
Copy link
Contributor

I've ported all the iterm2 color schemes to ones compatible with guake: https://github.com/varemenos/guake-color-palettes

let me know if you are interested in integrating them in guake.

@gsemet
Copy link
Member

gsemet commented Apr 11, 2015

Of course it would be interesting. However it will be quite hard for the user. I propose the following mutual work:

  • you integrate in a single Pull request ( ;) ) all these and prepare a small screen shot of each palette
  • I will then modify the preference panel so the user will directly see this picture automatically so he can choose more easily his prefered color scheme.

Of course, we can split the making of these screenshots in half so I can help you if you want.

@varemenos
Copy link
Contributor

There is one thing I'd like you to consider before continuing though. The current guake palettes don't set the foreground and background color of the terminal which makes most of them look "ugly" (since the colors don't fit). Would you consider adding those 2 color values to the palette settings as well? Here is an example of what values are set by the scripts.

@gsemet
Copy link
Member

gsemet commented Apr 11, 2015

ok, i see why you override /apps/guake/style/[font/background]/color. Ok, let me think on how to deal this this in an elegant fashion :)

@varemenos
Copy link
Contributor

Cool, just let me know when to start working on this

@gsemet
Copy link
Member

gsemet commented Apr 11, 2015

I think it will be pretty simple:

  • if palette is splitable in 16 parts, background and foreground will use default settings
  • if palette has extra 2 items, foreground and background will be overriden.

Ex:

tango

'#000000000000:#cccc00000000:#4e4e9a9a0606:#c4c4a0a00000:#34346565a4a4:'
'#757550507b7b:#060698209a9a:#d3d3d7d7cfcf:#555557575353:#efef29292929:'
'#8a8ae2e23434:#fcfce9e94f4f:#72729f9fcfcf:#adad7f7fa8a8:#3434e2e2e2e2:'
'#eeeeeeeeecec',

=> 16 parts

tango_forced

'#000000000000:#cccc00000000:#4e4e9a9a0606:#c4c4a0a00000:#34346565a4a4:'
'#757550507b7b:#060698209a9a:#d3d3d7d7cfcf:#555557575353:#efef29292929:'
'#8a8ae2e23434:#fcfce9e94f4f:#72729f9fcfcf:#adad7f7fa8a8:#3434e2e2e2e2:'
'#eeeeeeeeecec:#0000000:#FFFFFFFF"

=> 18 parts :)

I cannot work on this for the moment, but you can start doing screenshots (400x400 would be enough)

@gsemet
Copy link
Member

gsemet commented Apr 11, 2015

I don't know. Do it has sense to let the user change the color and background color on the palette?

@varemenos
Copy link
Contributor

I think that the front and background colors should be changed only in custom themes, doesn't that make more sense? Or if the user tries to change any color the palette setting should switch from a named palette to "custom". I will start working on those 400x400 screenshots now

@gsemet
Copy link
Member

gsemet commented Apr 11, 2015

let's have palette with 18 parts. 17th is background and 18th is foreground (font) colors

@varemenos
Copy link
Contributor

Could you please check this branch I've forked from master? I've gone ahead and fixed the old color palettes and loaded all the new ones I've ported from that iterm2 color schemes repository.

I wrote a node CLI that takes everything from that repository and prepares the Palettes=[] string for the prefs.py file.

I will take care of the screenshots later, I'm out of willpower 🍕

@gsemet
Copy link
Member

gsemet commented Apr 11, 2015

look good. i ve uploaded a version with foreground background readable from palette string. i let you sync with master...

for the screenshots, it should be really small actually, 150x150 only.

@gsemet
Copy link
Member

gsemet commented Apr 11, 2015

anyway, thank you very much for your work :) feel free to add yourself in the contribution file and in the about dialog

@varemenos
Copy link
Contributor

I can't seem to generate a decent screenshot of the color palette table, it seems like some columns are uneven (?).
screenshot from 2015-04-12 09-55-01

I just realized how annoying it will be to create a screenshot for 100+ color schemes 😄

@gsemet
Copy link
Member

gsemet commented Apr 12, 2015

let's forget about screenshot, l'll manage it differently. For me, you can
just prepare your PL

Also, is it possible for you to add tooltip with the meaning on each button
so the user can see which color matches which terminal "object", like I did
for background and font color on the two buttons I've added.


Gaetan

2015-04-12 9:01 GMT+02:00 Adonis K. [email protected]:

I can't seem to generate a decent screenshot of the color palette table,
it seems like some columns are uneven (?).
[image: screenshot from 2015-04-12 09-55-01]
https://cloud.githubusercontent.com/assets/626343/7104670/1fcc2cbc-e0fa-11e4-92b2-41eea01cc50a.png

I just realized how annoying it will be to create a screenshot for 100+
color schemes [image: 😄]


Reply to this email directly or view it on GitHub
#273 (comment).

@varemenos
Copy link
Contributor

Well, I'm not familiar with python but I will give it a try. I got the diffs from your commits so it will most probably be an easy job. Now I gotta figure out which colors does what :P

@gsemet
Copy link
Member

gsemet commented Apr 12, 2015

Just edit prefs.glade or use glade2 to edit it


Gaetan

2015-04-12 11:42 GMT+02:00 Adonis K. [email protected]:

Well, I'm not familiar with python but I will give it a try. I got the
diffs from your commits so it will most probably be an easy job. Now I
gotta find which colors does what :P


Reply to this email directly or view it on GitHub
#273 (comment).

@varemenos
Copy link
Contributor

I've tried searching descriptions for the palette but all I've found are vague descriptions like "Palette color 1", "Palette color 2" etc...

I will try searching a bit more and If I don't find anything better I will just leave them without labels for now

@gsemet
Copy link
Member

gsemet commented Apr 17, 2015

no pbl

@gsemet gsemet modified the milestones: 0.7.0, 1.0.0 Apr 23, 2015
gsemet added a commit to gsemet/guake that referenced this issue Apr 23, 2015
@gsemet gsemet closed this as completed Apr 28, 2015
gsemet added a commit that referenced this issue Jan 30, 2017
gsemet added a commit that referenced this issue Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants