Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tabs can not be opened via the tab bar. #1439

Closed
SparkyBluefang opened this issue Oct 6, 2018 · 10 comments
Closed

New tabs can not be opened via the tab bar. #1439

SparkyBluefang opened this issue Oct 6, 2018 · 10 comments

Comments

@SparkyBluefang
Copy link

Guake Terminal: 3.4.0
VTE: 0.48.4
VTE runtime: 0.48.4
Gtk: 3.22.30

In previous versions of Guake, new tabs could be opened by double-clicking the empty space on the tab bar, or by clicking the new tab button. With the Gtk.Notebook tab conversion, tabs can only be opened with the keyboard shortcut or through an existing tab's context menu.

@gsemet
Copy link
Member

gsemet commented Oct 8, 2018

indeed, this is a feature we do not have anymore, I didn't knew this was used by anyone. It makes sense to reset this feature. Pull Request accepted (should not be that hard to do :p )

@corvus1
Copy link

corvus1 commented Oct 8, 2018

I'm not sure about double-clicking, but the button I did use pretty regularly.

@white-gecko
Copy link

I was always using the double-click and was very confused, that it didn't work anymore. I still feels like a bug for me because it disturbed by usual behavior.

@quanzhuo
Copy link

@gsemet, @clarete , @aichingm , @piotrdrag I use double-click frequently. And want this feature back deeply. After review the code commit history, find that the following change removed the double-click feature

commit 0bc835c9420064c7a598e3efb9072aaa4e445bc5
Author: Mario Aichinger <[email protected]>
Date:   Wed Aug 15 22:29:33 2018 +0200

    disable custom tabs

diff --git a/data/guake.glade b/data/guake.glade
index d2d20a2..e848c85 100644

I tried to revert this commit , but lots of conflict in guake/guake_app.py. I am not familiar with the code. So It's diffcult for me to resolve the conflict. Could you please help make this feature back?

Thank you !
BRs

@piotrdrag
Copy link
Contributor

@quanzhuo Please don’t ping me on issues I have no relation to.

@quanzhuo
Copy link

Hi, piotrdrag, I found you are the main developer, so @ you. I am sorry for boring you, Thank you

@piotrdrag
Copy link
Contributor

I am not a developer.

@gsemet
Copy link
Member

gsemet commented Nov 21, 2018

Hi ! I a m, but no time to dig this issue yet :(

@revast
Copy link

revast commented Dec 2, 2018

+1, I also think this is a good idea to bring this back. Especially for newbies, the button makes sense.

  • There is no new tab/close tab in the context menu, which I think should be there as well.

  • Plus, it would be nice to have the new tabs button configurable in Preferences. I always edited the glade file to put it on left side of the tabs (makes more sense to me, less mouse travel...) , so having this configurable (show left, right, and do not show) would be a real win.

  • I also changed the icon to something more obvious (a black plus sign add_tab) which I can provide if others like it.

@Yakoot
Copy link

Yakoot commented Dec 15, 2018

i was confused after upgrading that i cannot open a new tab) i hope it will be realized again

amezin added a commit to amezin/guake that referenced this issue Jan 5, 2019
Fixes Guake#1439

sem-ver: feature

Signed-off-by: Aleksandr Mezin <[email protected]>
gsemet pushed a commit that referenced this issue Jan 7, 2019
Fixes #1439

sem-ver: feature

Signed-off-by: Aleksandr Mezin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants