Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gtk3] Scrollback lines not configurable #1082

Closed
egmontkob opened this issue Jan 15, 2018 · 6 comments
Closed

[gtk3] Scrollback lines not configurable #1082

egmontkob opened this issue Jan 15, 2018 · 6 comments

Comments

@egmontkob
Copy link

"Scrolling" tab.

The input field for the "Scrollback lines" number is active, however, the - and + buttons are insensitive. No matter what I type for the number (which is 0 initially), the scrollback is only 1024 lines. As I close and reopen the prefs window, the number is 0 again.

Expected: -/+ buttons active. The displayed number reflects the current value. The entered number is saved respected. Ideally another option (checkbox) for infinite scrollback.

(Technical: VTE stores the scrollback in compressed and encrypted, unlinked temporary files under /tmp.)

On a side note, the checkboxes "On output" and "On key stroke" don't make too much sense to me without a header like "Scroll to bottom".

@egmontkob
Copy link
Author

Let me mention here that the other GtkSpinButton, namely "Max tab name length" on the General tab also suffers from the same problem.

@gsemet gsemet added this to the 3.0.2 milestone Jan 21, 2018
gsemet added a commit that referenced this issue Jan 21, 2018
@gsemet gsemet closed this as completed in f7105f2 Jan 21, 2018
@egmontkob
Copy link
Author

Thanks!

Some followup nitpicking:

The default value is 1024. The +/- buttons jump on multiples of 1000, and any manually entered value is also rounded.

  • The default should be a value that is also configurable later.

  • Spinbuttons can be set up in a way that the +/- buttons jump in bigger steps, yet any value entered in between is also accepted.

  • There's no technical reason in VTE for preferring powers of two at all. IMHO the default should be a more user-friendly value (a round number in decimal rather than binary).

@egmontkob
Copy link
Author

By the way, jumping by 1000 is a really nice thing that I'd like to have for gnome-terminal too :-)

@gsemet
Copy link
Member

gsemet commented Jan 21, 2018

I agree :) would be fun to have a exponential-like (rounded to 100s) increment

gsemet added a commit that referenced this issue Jan 21, 2018
gsemet added a commit that referenced this issue Jan 21, 2018
@sp4c30x1
Copy link

sp4c30x1 commented Feb 7, 2018

how can i set infinite scroll ?

@gsemet
Copy link
Member

gsemet commented Feb 7, 2018

Update to HEAD?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants