Skip to content

Commit

Permalink
Remove dead functions, replace pass with NotImplementedError
Browse files Browse the repository at this point in the history
  • Loading branch information
Davidy22 authored and gsemet committed Sep 13, 2021
1 parent 7e815ce commit bb4e839
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 28 deletions.
21 changes: 9 additions & 12 deletions guake/boxes.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,31 +35,31 @@ class TerminalHolder:
LEFT = 3

def get_terminals(self):
pass
raise NotImplementedError

def iter_terminals(self):
pass
raise NotImplementedError

def replace_child(self, old, new):
pass
raise NotImplementedError

def get_guake(self):
pass
raise NotImplementedError

def get_window(self):
pass
raise NotImplementedError

def get_settings(self):
pass
raise NotImplementedError

def get_root_box(self):
pass
raise NotImplementedError

def get_notebook(self):
pass
raise NotImplementedError

def remove_dead_child(self, child):
pass
raise NotImplementedError


class RootTerminalBox(Gtk.Overlay, TerminalHolder):
Expand Down Expand Up @@ -293,9 +293,6 @@ def remove_dead_child(self, child):
page_num = self.get_notebook().page_num(self)
self.get_notebook().remove_page(page_num)

def move_focus(self, direction, fromChild):
pass

def block_notebook_on_button_press_id(self):
GObject.signal_handler_block(
self.get_notebook(), self.get_notebook().notebook_on_button_press_id
Expand Down
18 changes: 2 additions & 16 deletions guake/simplegladeapp.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def __init__(self, path, root=None, domain=None):
# self.glade = self.create_glade(self.glade_path, root, domain)

self.normalize_names()
self.new()
# Widgets are loaded and can be refered as self.widget_name

def __repr__(self):
class_name = self.__class__.__name__
Expand All @@ -83,13 +83,6 @@ def __repr__(self):
repr = '%s(path="%s")' % (class_name, self.glade_path)
return repr

def new(self):
"""
Method called when the user interface is loaded and ready to be used.
At this moment, the widgets are loaded and can be refered as self.widget_name
"""
pass

def add_callbacks(self, callbacks_proxy):
"""
It uses the methods of callbacks_proxy as callbacks.
Expand Down Expand Up @@ -253,14 +246,7 @@ def run(self):
try:
self.main()
except KeyboardInterrupt:
self.on_keyboard_interrupt()

def on_keyboard_interrupt(self):
"""
This method is called by the default implementation of run()
after a program is finished by pressing Control-C.
"""
pass
sys.exit()

def get_widget(self, widget_name):
return self.builder.get_object(widget_name)
Expand Down

0 comments on commit bb4e839

Please sign in to comment.