Make startup script non-blocking

Guake · Apr 6, 2022 · adb397c · adb397c
1 parent 2081945
commit adb397c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/guake/main.py b/guake/main.py
@@ -612,15 +612,15 @@ def main():
             startup_script = instance.settings.general.get_string("startup-script")
             if startup_script:
                 log.info("Calling startup script: %s", startup_script)
-                with subprocess.Popen(
-                    [startup_script],
-                    shell=True,
+                pid = subprocess.Popen(
+                    [startup_script],  # pylint: disable=consider-using-with
+                    shell=False,
                     stdin=None,
                     stdout=None,
                     stderr=None,
                     close_fds=True,
-                ) as pid:
-                    log.info("Startup script started with pid: %s", pid)
+                )
+                log.info("Startup script started with pid: %s", pid)
                 # Please ensure this is the last line !!!!
     else:
         log.info("--no-startup-script argument defined, so don't execute the startup script")

diff --git a/releasenotes/notes/make_startup_script_nonblocking-f73468e705fa712b.yaml b/releasenotes/notes/make_startup_script_nonblocking-f73468e705fa712b.yaml
@@ -0,0 +1,3 @@
+fixes:
+  - |
+      - Hooks > onStart delay Guake start by ~100s #1982