Use monkeypatch.setenv instead of copying the os.environ for tests.

Guake · Apr 19, 2022 · 7a5942e · 7a5942e
1 parent 1da807b
commit 7a5942e
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/guake/tests/test_about.py b/guake/tests/test_about.py
@@ -9,15 +9,10 @@
 
 
 @pytest.fixture
-def dialog(mocker):
+def dialog(mocker, monkeypatch):
     mocker.patch("guake.simplegladeapp.Gtk.Widget.show_all")
-    try:
-        old_os_environ = os.environ
-        os.environ["LANGUAGE"] = "en_US.UTF-8"
-        ad = AboutDialog()
-        yield ad
-    finally:
-        os.environ = old_os_environ
+    monkeypatch.setenv("LANGUAGE", "en_US.UTF-8")
+    yield AboutDialog()
 
 
 def test_version_test(dialog):