-
Notifications
You must be signed in to change notification settings - Fork 579
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix fullscreen/unfullscreen not handle correctly when trigger by wind…
…ow manager Expect handling from accel-key fullscreen toggle, also handle from window state changed. Because if you bind same accel-key for fullscreen in window manager, you will not trigger it from Guake toggle fullscreen, instead from wm. This should fix wierd window size & position when first using Guake fullscreen toggle, then toggle fullscreen by wm hotkey.
- Loading branch information
Showing
3 changed files
with
16 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
releasenotes/notes/fix-fullscreen-handle-in-wm-trigger-a1e3205ec1ec3cac.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
fixes: | ||
- Fix fullscreen/unfullscreen not handle correctly when trigger by wm |
5205ce2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to cause this #1720
5205ce2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit breaks the "Appear on mouse display" feature when using multi-monitor setups, see #1720, #1738.
5205ce2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on i3wm, this commit breaks placement. Every toggle of guake moves the terminal slightly down-right its previous position