Fix prompt on close tab

PromptQuitDialog creation had wrong number of arguments, last argument is unused in this situation so passed None into it.
Guake · Sep 10, 2021 · 0eecd43 · 0eecd43
1 parent 7f4920f
commit 0eecd43
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/guake/notebook.py b/guake/notebook.py
@@ -294,7 +294,7 @@ def delete_page(self, page_num, kill=True, prompt=0):
         procs = self.get_running_fg_processes_count_page(page_num)
         if prompt == 2 or (prompt == 1 and procs > 0):
             # TODO NOTEBOOK remove call to guake
-            if not PromptQuitDialog(self.guake.window, procs, -1).close_tab():
+            if not PromptQuitDialog(self.guake.window, procs, -1, None).close_tab():
                 return
 
         page = self.get_nth_page(page_num)

diff --git a/releasenotes/notes/fix_prompt_when_close_tab-c808afd378a1b33a.yaml b/releasenotes/notes/fix_prompt_when_close_tab-c808afd378a1b33a.yaml
@@ -0,0 +1,6 @@
+release_summary: >
+  Fixes prompting when closing a tab.
+
+fixes:
+  - |
+      - Fixes #1863