Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing checks in paginated results #12

Merged
merged 4 commits into from
Oct 2, 2023

Conversation

eanrollings
Copy link
Contributor

also, bumping version

@eanrollings eanrollings changed the title Adding missing check for group in paginated results Adding missing checks in paginated results Sep 29, 2023
@eanrollings
Copy link
Contributor Author

@GtheSheep Let me know if should not have touched that VERSION file :)
... or if there is anything else I should add. The paginated code you wrote so nicely was just not checking each page for the matched object. I saw you had some TODO code about consolidating the pagination but I took the easy way out and just added the missing code to the respective places.

@GtheSheep GtheSheep merged commit d75e7f6 into GtheSheep:main Oct 2, 2023
@GtheSheep
Copy link
Owner

@eanrollings - yep, that's my bad for not doing my TODOs! 😅 thanks for adding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants