File name changed to utils.js #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atherdon
requested changes
Apr 11, 2019
There was a problem hiding this comment.
This task is not so easy as it can look for the first time.
As you may know - files are frequently used inside of the module and imported each time when it used. This file is important, and by just renaming it - you'll crash our module. take some and think what else should be changed
|
so I should find "helper.js" from the entire repository(wherever it is used
in all the modules) and replace it with "utils.js. Am I right?
…On Thu, Apr 11, 2019 at 2:48 AM Arthur Tkachenko ***@***.***> wrote:
***@***.**** requested changes on this pull request.
This task is not so easy as it can look for the first time.
As you may know - files are frequently used inside of the module and
imported each time when it used. This file is important, and by just
renaming it - you'll crash our module. take some and think what else should
be changed
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#339 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APgcs0rg0Oayq1y6CnaG9QNIW0YcdcEYks5vfwT8gaJpZM4cobFl>
.
|
|
you can search at `src`/projects/` only
|
atherdon
approved these changes
Apr 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.