-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renderer Method re-ogranization. Refactoring #50
Comments
@atherdon I think we can creacte a class that will contains mathods from Method.js. And creacte some setters to give data in class. |
ok, but i want to have here more details. like a step-by-step plan about how it can be improved. Not sure if'm 100% ok with idea of making class, but let's explore that way anyway... |
We can add in dishByDay array with ingredients |
i should have more details. |
method renderFunc() render a dish in one day and display modal with ingredients when you will click on a tile. Component ColumnRender specify what day should display renderFunc |
if we have 5 recipes - we also have 5 modals at our HTML page with
different lists, or we have one modal - that refresh content?
…On Sun, Oct 21, 2018 at 7:33 PM Vadim ***@***.***> wrote:
method renderFunc() render a dish in one day and display modal with
ingredients when you will click on a tile
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#50 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABZrDjoqz8tVjPmNNtMysYiolbCAgAmWks5unKHIgaJpZM4Xx6JU>
.
|
We have 5 modules |
this thing is maybe not related to our current task, but we should think
about it too.
I'm still cannot figure out how to improve this method, without looking at
it's code.
Can you guide me somehow, so i can easily figure it out?
…On Sun, Oct 21, 2018 at 8:05 PM Vadim ***@***.***> wrote:
We have 5 modules
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#50 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABZrDmOHZqAfY8LPHYx-t3b-1sKFeW2Mks5unKlDgaJpZM4Xx6JU>
.
|
function getOffset calculate and return object with position for one column. (in code it's buffer)
Next create Modals that have ingredients
In Modals we give name of meal, time, and ingredients. Modals is a tile. When you click it, open form with ingredients. In this way 5 tiles are 5 Modals in calendar. |
yep, this is what i assumed. Ok, no problem - we'll change it
|
Our main goal here - to discuss how we can improve this function.
But firstly - please explain what exactly this function doing and why we put there a lot of data...
link to our chat: #48 (comment)
The text was updated successfully, but these errors were encountered: