Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional keymappings/functions and documentation #63

Open
GrimSqueaker opened this issue Feb 24, 2021 · 3 comments
Open

Additional keymappings/functions and documentation #63

GrimSqueaker opened this issue Feb 24, 2021 · 3 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request question Further information is requested

Comments

@GrimSqueaker
Copy link
Owner

Hi,

I have prepared a branch https://github.com/GrimSqueaker/remc2/tree/keymappings with two new keyboard shortcuts and one of which slightly modifies the keymapping.

SDL Window Grab:
Via CTRL-F10 window grabbing can be enabled and disabled. I wanted this in the first place, because when playing in window mode the cursor can leave the window and playing is really hard. But the problem then on my box is, that when the game crashes Visual Studio code does not get back a mouse cursor and I cannot debug properly. This way I can now disable the grab.
This is actually the same shortcut as DOSBOX uses for mouse grabbing.

WASD keys:
In the past the default keymap did not bother me. But nowadays WASD is the default. So I map WASD to the arrow keys and to make it a bit easier I also map LSHIFT to RCTRL. This is disabled by default and can be enabled via CTRL-F11.

Do you have other ideas for improvements?

I know that the current implementation is sub-optimal. For one, the WASD mapping probably does not allow to use these letters in save game names. If you think that the WASD mapping makes sense, I would try to improve the implementation.
I think I would like to avoid a freely configurable keymapping via config files, because it is not worth the effort. But at least it would make sense to document the keymappings (not just the new mappings).
Maybe in the README.md or another .md? Or should we start writing some proper documentation? Doxygen or something similar?

Cheers,
Sebastian

@GrimSqueaker GrimSqueaker added documentation Improvements or additions to documentation enhancement New feature or request question Further information is requested labels Feb 24, 2021
@turican0
Copy link
Collaborator

turican0 commented Feb 26, 2021

Hi Seb,
you're right, WASD is batter than arrows, some this this keys may be used.

D Options panel
S Toggle stereo mode on/off

When saving I did not notice that the mapped keys could not be used. So far I would only deal with readme.md, oxyfen may be later. We can start from the readme in the project and from the original manual,
Tom.

https://www.abandonwaredos.com/docs.php?sf=magiccarpet2readme.txt&st=manual&sg=Magic+Carpet+2%3A+The+Netherworlds&idg=2966

@turican0
Copy link
Collaborator

Before anything changes keymapping please read code in procedure sub_17190, and etc.
Tom.

@GrimSqueaker
Copy link
Owner Author

I will take a look and try to come up with a better solution. For the moment it is anyhow not the default.

GrimSqueaker pushed a commit that referenced this issue Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants