Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependency versions #867

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aaronsmulktis
Copy link

@aaronsmulktis aaronsmulktis commented Oct 22, 2022

Griddle major version

1.14.0

Changes proposed in this pull request

Modify package.json & package-lock.json

Why these changes are made

Upgrading packages addressing critical security vulnerabilities

Are there tests?

No

@aaronsmulktis aaronsmulktis changed the title tweak dependency versions update dependency versions Oct 22, 2022
@ryanlanciaux
Copy link
Member

This looks great! Thank you for adding it!

I'm wondering if you're seeing this same thing that I am locally on running the start script

ERR! TypeError: Cannot read properties of undefined (reading 'module')
ERR!     at module.exports (~/projects/javascript/Griddle/.storybook/webpack.config.js:3:10)

@aaronsmulktis aaronsmulktis marked this pull request as draft October 23, 2022 12:16
@aaronsmulktis
Copy link
Author

Yep @ryanlanciaux, sorry meant to save this as a draft.
I also saw a few tests failing.

Still working on this!
Will update soon...

@ryanlanciaux
Copy link
Member

Haha, no worries - wanted to make sure I wasn't missing something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants