Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import lodash functions instead of whole lib #857

Merged
merged 2 commits into from
Jul 9, 2019

Conversation

lvaldovinos
Copy link

Griddle major version

1.x

Changes proposed in this pull request

Import lodash functions that are used in code, instead of whole lodash lib.

Why these changes are made

#854 was created and requested by @ryanlanciaux

Are there tests?

No, existing tests weren't changed.

@lvaldovinos
Copy link
Author

@ryanlanciaux @docrinehart endsWith problem is related to reducer object has extra symbol property (not sure if this symbol property is added by webpack), so when it's passed to buildGriddleReducer it throws error, I've fixed it by making sure all keys provided in reducerObject are indeed string, hope it's okay.

Copy link
Contributor

@StevenTCramer StevenTCramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick review and looks good to me. Thanks, @lvaldovinos

src/utils/compositionUtils.js Show resolved Hide resolved
src/utils/compositionUtils.js Show resolved Hide resolved
@ryanlanciaux ryanlanciaux merged commit 184fc32 into GriddleGriddle:master Jul 9, 2019
@ryanlanciaux
Copy link
Member

Will do a little more testing on this and get an alpha release out for folks to try (followed by an actual release) Thanks again @lvaldovinos 🚀 this is great.

@docrinehart
Copy link

Fixes #854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants