Upgrade typescript to ^2.8.0 #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should hopefully fix error in travis build step `npm run check-ts` Error: node_modules/@types/recompose/index.d.ts(23,47): error TS2304: Cannot find name 'Exclude'. Example build: https://travis-ci.org/GriddleGriddle/Griddle/builds/441174637 Reason: The Exclude keyword used in @types/recompose was added in Typescript 2.8 (https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-8.html#predefined-conditional-types).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Griddle major version
v1
Changes proposed in this pull request
Upgrade typescript to ^2.8.0
Why these changes are made
This should hopefully fix error in travis build step
npm run check-tsError:
Failing builds:
https://travis-ci.org/GriddleGriddle/Griddle/builds/441174637
https://travis-ci.org/GriddleGriddle/Griddle/builds/450669719
Reason: The Exclude keyword used in @types/recompose was added in
Typescript 2.8
(https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-8.html#predefined-conditional-types).
Are there tests?
Successful CI is the test.