Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Virtual/infinite scroll (PositionPlugin) flicker #832

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add repro story for PositionPlugin flicker
  • Loading branch information
dahlbyk committed Sep 3, 2018
commit 2049192980b5d24cde3ebe17dcf07c51a68d911d
23 changes: 23 additions & 0 deletions stories/index.tsx
Original file line number Diff line number Diff line change
@@ -797,6 +797,29 @@ storiesOf('Griddle main', module)
</Griddle>
)
})
.add('with virtual scrolling and tall rows', () => {
const data = [];
for (let i = 0; i < 100; i++) {
data.push({
name: 'asdasd asdasd asdasd '.repeat(4 + 3 * Math.random()),
age: 18 + Math.floor(Math.random() * 70),
active: 'false',
action: 'action',
address: 'asdasd asdasd asdasd '.repeat(6 + 2 * Math.random()),
});
}
return (
<Griddle data={data} plugins={[LocalPlugin, PositionPlugin({ tableHeight: 300 })]}>
<RowDefinition>
<ColumnDefinition id="name" width={400} filterable />
<ColumnDefinition id="age" />
<ColumnDefinition id="active" />
<ColumnDefinition id="action" />
<ColumnDefinition id="address" width={400} filterable />
</RowDefinition>
</Griddle>
)
})
.add('set fakeData to constructed Objects', () => {
type Griddle = new () => GenericGriddle<person>;
const Griddle = GenericGriddle as Griddle;