Implement ColumnDefinition extraData #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: most props were not passed down through CellContainer.
Technically, extraData was already available via cellProperties, but this is easier to use. extraData properties are spread into props for: - TableHeadingCell - Cell - customHeadingComponent - customComponent
|
Awesome thank you! 👍 |
This was referenced Jun 13, 2017
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Griddle major version
1.x
Changes proposed in this pull request
Expand
ColumnDefinitionextraDataintopropsforTableHeadingCell,Cell,customHeadingComponentandcustomComponent.The v0 implementation of
globalDatapassedglobalDatathrough directly; it's trivial to switch this implementation to pass through anextraDataprop, if that would be preferred.Why these changes are made
Closes #674
Are there tests?
Story!