Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add onSelectionChange and persist selectedRowIds across pages #508

Merged
merged 1 commit into from
Nov 8, 2016
Merged

add onSelectionChange and persist selectedRowIds across pages #508

merged 1 commit into from
Nov 8, 2016

Conversation

tim-phillips
Copy link
Contributor

I've implemented an onSelectionChange callback that the user can use. I needed it for a project of mine and couldn't figure out how to get Griddle 1.0 working, so here are my changes.

A number of these changes are cosmetic, the formatting in the existing multiple selection code was pretty inconsistent.

I don't know why my .js files are so much longer than other peoples' changes, but this is what I got when I built with grunt.

Please let me know if you have any questions or issues with these commits.

@tim-phillips
Copy link
Contributor Author

For reference: #125, #144, #151, #153, #175, #218, #230, #234

@ryanlanciaux
Copy link
Member

Thanks so much - one of us will test it out a bit more and try to get things merged + published today / tomorrow.

@joellanciaux joellanciaux merged commit 6b5c55d into GriddleGriddle:master Nov 8, 2016
@joellanciaux
Copy link
Member

Thank you for putting this together! 👍

@tim-phillips
Copy link
Contributor Author

You got it!

@nickwang14
Copy link

Is there documentation on how to implement this when using griddles? I don't see any references to checkboxes in the documentation.

Note: I saw current documentation is v0, does that mean these changes have been merged but not released?

@dahlbyk
Copy link
Contributor

dahlbyk commented Feb 1, 2019

I never worked with Griddle 0.x, so I can't speak to this feature, but this appears to be part of v0.8.2 (#809).

As far as I know v1 doesn't have an equivalent feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants