Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced filtering added #177

Closed
wants to merge 3 commits into from

Conversation

CezaryDanielNowak
Copy link

Possible filtering

// griddle.setFilter(filter):
filter = {
    columnName: "value",
    column2: "value2"
};
filter = [
    {columnName: "sth"},
    "filterAllColumns"
];
filter = /\S+@\S+\.\S+/; // regexp
filter = "works as before";

Some documentation is required, but I won't have time for doing this :-<

@CezaryDanielNowak
Copy link
Author

ps. my editor unified tabs and spaces, I hope, this won't be a problem.

@kevinold
Copy link
Contributor

@CezaryDanielNowak Thank you for your PR. In order to be approved and merged please:

  1. submit .editorconfig in a separate PR
  2. Provide tests and documentation patches for the proposed filtering

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants