Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'filterable' parameter to columnMetaData #66

Closed
nlien opened this issue Feb 2, 2015 · 9 comments
Closed

Add 'filterable' parameter to columnMetaData #66

nlien opened this issue Feb 2, 2015 · 9 comments

Comments

@nlien
Copy link

nlien commented Feb 2, 2015

Hi! First off; thanks for this library- and its ease of use. Nice to see good documentation, especially with lots of examples.

I see that the 'sortable' parameter for columnMetaData has gotten into the code, but it's still not documented.

I'd love to see a boolean parameter (t.ex. 'filterable'), which excludes/includes that particular column when performing filtering.

@nlien
Copy link
Author

nlien commented Feb 3, 2015

Is this something you are planning to implement?

@ryanlanciaux
Copy link
Member

Hey @nlien Thank you for the kind words! This is a fantastic idea and is something we plan on implementing in the near future.

@mhuggins
Copy link

+1, would love to see this!

@tony-kerz
Copy link

i would love to see a variation of this where a filterable property set to true for a column would provide a column specific filter input, something similar to this: http://allenfang.github.io/react-bootstrap-table/example.html#filter

@ryanlanciaux
Copy link
Member

Cool - we are planning on supporting this type of functional as a plugin after 1.0 ships :) If anyone wants to try their hand at it beforehand, please ping me and I'll help you get setup on that :)

@karthikiyengar
Copy link
Contributor

I would love to take a crack at this if this is still relevant (and if it falls within my capabilities 😄). Please let me know if there is anything I should know before I get started on this.

@ryanlanciaux
Copy link
Member

That would be awesome. I think the operation should mostly be in here https://github.com/GriddleGriddle/Griddle/blob/master/scripts/griddle.jsx#L148. I think right before checking the column against the filter string, we would want to make sure that the column is not filterable={false}. Please let me know if that helps.

karthikiyengar added a commit to karthikiyengar/Griddle that referenced this issue Jun 17, 2016
@karthikiyengar
Copy link
Contributor

Thanks for the pointer, Ryan - certainly was helpful. Please let me know my changes are not adequate.

ryanlanciaux added a commit that referenced this issue Jul 3, 2016
#66, #30 - Support filterable property in columnMetadata
@sww314
Copy link

sww314 commented Jul 20, 2017

Closed by #436

@sww314 sww314 closed this as completed Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants