-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Row events #64
Comments
Thanks for posting this! Currently this isn't something that can be done easily but we are adding some ways to easily have events on these items. |
I was playing around with this and I used the useCustomRowComponent and customRowComponent to add another component (and add the event in the other components). However it removed the default formatting (column header and spacings) of the original table. Any suggestions on how to go about and integrate them together? var Popup2 = React.createClass({ {this.props.data} I'm a popup! ) } }); |
I've currently added an 'onRowClick' prop to Griddle, and then pass that down to gridTable, gridRowContainer and then gridRow. The callback receives the row data and a few other props. Would this be an acceptable feature for a pull request? |
That would be excellent 👍 |
Just checking on the status of this. @Nextminds your changes look good to me. Any reason you haven't submitted a PR? |
All, we're closing this in favor of GriddleGriddle/griddle-render#15 that we're treating as acceptance criteria for the more modularized components that we're working towards. Please feel free to let us know of any questions 👍 |
I'm confused -- the Properties documentation shows onRowClick, but it seems like it's not actually implemented yet. What's the scoop? |
…or onRowWillMount, onRowWillUnmount events; [FIX] GriddleGriddle#64;
Apologies if I missed this in the documentation but I'd like a way to have events when rows are interacted with. Namely if they are clicked or hovered over. Is this doable? Thanks!
The text was updated successfully, but these errors were encountered: