Fix python build #264
Merged
Fix python build #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there, this is jenkins continuous integration... |
halungge
commented
Jan 17, 2023
halungge
force-pushed
the
fix_python_build
branch
from
00a4c35
to
debd5cb
Compare
- run tests with pytest - run on ubuntu runner directly
- run tests with pytest - run on ubuntu runner directly
halungge
force-pushed
the
fix_python_build
branch
from
d778276
to
8e5e0fd
Compare
|
ok to test |
|
launch jenkins |
havogt
approved these changes
Jan 25, 2023
.github/workflows/CI.yml
Outdated
Comment on lines
130
to
132
|
|
||
| - name: clean up | ||
| run: pip uninstall --yes serialbox |
There was a problem hiding this comment.
Why? Is this explicitly testing that uninstall doesn't break?
There was a problem hiding this comment.
Don't know whether this makes sense, I added it because of the caching. I don't want the serialbox installation to be cached.
There was a problem hiding this comment.
There should be no caching. Maybe let's remove then, as later we might be confused why it's there.
havogt
reviewed
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
${ORIGIN}to the buildrpathfor python buildwhen running the python build with pip
the cmake build target is run, after that the shared libraries are copied from the build folder to
site_packagesfolder of the python environment. Adding${ORIGIN}to therpathallowscdll.LoadLibraryto find dependent libraries in the current folder.