fix[next][dace]: Fixing Strides Reconstruction During Propagation #1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NestedSDFG essentially allows to perform some slices, there are technically three chases: - The data container on the inside has a smaller rank than the one on the outside, thus some dimensions were removed. - The data container on the inside has the same rank than the one on the outside. - The data container on the inside has a larger rank than the one on the outside, thus some dimensions were added. The last case is not handled, as it does not happens in GT4Py. Before, the first and second case were handled together, but it was realized that the second case was not implemented properly and it was added explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NestedSDFG essentially allows to perform some slices, there are technically three chases:
The last case is not handled, as it does not happens in GT4Py. Before, the first and second case were handled together, but it was realized that the second case was not implemented properly and it was added explicitly.
This PR fixes the issues with
TestFusedVelocityAdvectionStencil1To7andTestFusedVelocityAdvectionStencil8To13in ICON4Py#638, however, the later test now fails with a segmentation fault.