feat[next]: allow import of Dimensions from modules within gt4py code #1615

nfarabullini · 2024-08-15T13:11:45Z

Allow to import module attributes directly in gt4py code, e.g. in domainhere:

    @gtx.program
    def prog(f: gtx.Field[Dims[IDim], float], out: gtx.Field[Dims[IDim], float]):
        field_op(f, out=out, domain={dims.IDim: (0, 8)})

src/gt4py/next/ffront/func_to_past.py

src/gt4py/next/ffront/program_ast.py

src/gt4py/next/ffront/func_to_past.py

Co-authored-by: Hannes Vogt <[email protected]>

src/gt4py/next/type_system/type_translation.py

tests/next_tests/integration_tests/feature_tests/ffront_tests/test_import_from_mod.py

src/gt4py/next/ffront/func_to_past.py

src/gt4py/next/ffront/program_ast.py

Co-authored-by: Hannes Vogt <[email protected]>

…test_import_from_mod.py Co-authored-by: Hannes Vogt <[email protected]>

…gt4py into module_import_impl

tests/next_tests/integration_tests/feature_tests/ffront_tests/test_import_from_mod.py

…test_import_from_mod.py

…odule_import_impl

havogt

this is also a leftover from the other strategy

src/gt4py/next/type_system/type_translation.py

tests/next_tests/integration_tests/feature_tests/ffront_tests/test_import_from_mod.py

tests/next_tests/unit_tests/type_system_tests/dummy_package/__init__.py

tests/next_tests/integration_tests/feature_tests/ffront_tests/test_import_from_mod.py

…test_import_from_mod.py

tests/next_tests/integration_tests/feature_tests/ffront_tests/test_import_from_mod.py

havogt

Looks good to me! Thanks!

nfarabullini added 9 commits August 15, 2024 15:07

import dims in field_op domain in prog

56b04f4

small edit

4210d04

included type in past.AttributeExpr

c0e41f0

some cleanup

bbe4257

some cleanup

8d5e59e

some cleanup

c2175db

edits to test

ec849aa

Update type_deduction.py

8474af8

Update type_deduction.py

a0e70bd

havogt reviewed Aug 15, 2024

View reviewed changes

src/gt4py/next/ffront/func_to_past.py Show resolved Hide resolved

src/gt4py/next/ffront/program_ast.py Outdated Show resolved Hide resolved

src/gt4py/next/ffront/program_ast.py Outdated Show resolved Hide resolved

src/gt4py/next/ffront/func_to_past.py Outdated Show resolved Hide resolved

nfarabullini and others added 3 commits August 16, 2024 08:37

Update src/gt4py/next/ffront/program_ast.py

41b6099

Co-authored-by: Hannes Vogt <[email protected]>

Merge branch 'main' into module_import_impl

eb2eaee

edits to test to include all backends

5a93b0f

havogt reviewed Aug 19, 2024

View reviewed changes

nfarabullini and others added 16 commits August 19, 2024 09:50

Update src/gt4py/next/type_system/type_translation.py

e35d898

Co-authored-by: Hannes Vogt <[email protected]>

Update tests/next_tests/integration_tests/feature_tests/ffront_tests/…

256a5ef

…test_import_from_mod.py Co-authored-by: Hannes Vogt <[email protected]>

Update tests/next_tests/integration_tests/feature_tests/ffront_tests/…

ef29b38

…test_import_from_mod.py Co-authored-by: Hannes Vogt <[email protected]>

changes following review

c7beb36

changes to allow for module import in field_operator

345da57

small edit to test

c2caba0

ran pre-commit

ec1129b

edits for closure_vars and following chain

ceb7fac

pull from Hannes' branch

70718e8

edits following merge

f61f55f

removed edits from other changes

c1ba851

Merge branch 'main' into module_import_impl

1112b6d

changes following review

ed88398

Merge branch 'module_import_impl' of https://github.com/nfarabullini/…

6767447

…gt4py into module_import_impl

further cleanup

ab55b7a

small edit

36d7dcb

nfarabullini changed the title ~~Allow import from modules within gt4py code~~ feat [next]: allow import from modules within gt4py code Aug 26, 2024

removed one last unused component

87dd95e

nfarabullini requested a review from havogt August 26, 2024 07:16

edit to include dimension module import in field_operator

8bef26b

nfarabullini commented Aug 27, 2024

View reviewed changes

tests/next_tests/integration_tests/feature_tests/ffront_tests/test_import_from_mod.py Outdated Show resolved Hide resolved

nfarabullini commented Aug 27, 2024

View reviewed changes

tests/next_tests/integration_tests/feature_tests/ffront_tests/test_import_from_mod.py Outdated Show resolved Hide resolved

nfarabullini added 4 commits August 27, 2024 11:42

Update tests/next_tests/integration_tests/feature_tests/ffront_tests/…

a4bcb40

…test_import_from_mod.py

small import edit

41b7815

further edits

cbb4fe0

Merge branch 'master' of https://github.com/nfarabullini/gt4py into m…

8c439de

…odule_import_impl

havogt requested changes Aug 27, 2024

View reviewed changes

src/gt4py/next/type_system/type_translation.py Outdated Show resolved Hide resolved

more edits and other tests

1469761

nfarabullini requested a review from havogt August 27, 2024 13:51

edits for error tests

a11ad76

havogt reviewed Aug 28, 2024

View reviewed changes

tests/next_tests/integration_tests/feature_tests/ffront_tests/test_import_from_mod.py Outdated Show resolved Hide resolved

havogt reviewed Aug 28, 2024

View reviewed changes

tests/next_tests/integration_tests/feature_tests/ffront_tests/test_import_from_mod.py Outdated Show resolved Hide resolved

havogt reviewed Aug 28, 2024

View reviewed changes

tests/next_tests/integration_tests/feature_tests/ffront_tests/test_import_from_mod.py Show resolved Hide resolved

havogt reviewed Aug 28, 2024

View reviewed changes

tests/next_tests/unit_tests/type_system_tests/dummy_package/__init__.py Outdated Show resolved Hide resolved

edits following review

7e7bb03

nfarabullini commented Aug 28, 2024

View reviewed changes

tests/next_tests/integration_tests/feature_tests/ffront_tests/test_import_from_mod.py Outdated Show resolved Hide resolved

nfarabullini added 3 commits August 28, 2024 14:57

Update tests/next_tests/integration_tests/feature_tests/ffront_tests/…

44c3cc9

…test_import_from_mod.py

ran pre-commit

ab9a137

small edit to test

8021f28

havogt reviewed Aug 28, 2024

View reviewed changes

tests/next_tests/integration_tests/feature_tests/ffront_tests/test_import_from_mod.py Outdated Show resolved Hide resolved

edits following review

c7f85e7

nfarabullini requested a review from havogt August 28, 2024 14:51

havogt approved these changes Aug 29, 2024

View reviewed changes

havogt changed the title ~~feat [next]: allow import from modules within gt4py code~~ feat[next]: allow import of Dimensions from modules within gt4py code Aug 29, 2024

nfarabullini merged commit 28c1ca8 into GridTools:main Aug 29, 2024
31 checks passed

halungge mentioned this pull request Sep 3, 2024

Microphysics package with saturation adjustment C2SM/icon4py#522

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat[next]: allow import of Dimensions from modules within gt4py code #1615

feat[next]: allow import of Dimensions from modules within gt4py code #1615

nfarabullini commented Aug 15, 2024

havogt left a comment

havogt left a comment

feat[next]: allow import of Dimensions from modules within gt4py code #1615

feat[next]: allow import of Dimensions from modules within gt4py code #1615

Conversation

nfarabullini commented Aug 15, 2024

havogt left a comment

Choose a reason for hiding this comment

havogt left a comment

Choose a reason for hiding this comment