Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[next][dace]: Fix GTIR-to-SDFG lowering for failing tests #1609

Merged
merged 7 commits into from
Aug 16, 2024

Conversation

edopao
Copy link
Contributor

@edopao edopao commented Aug 8, 2024

This PR addresses some problems encountered during GTIR/DaCe integration.

  • Handle field size symbol as explicit scalar argument
  • Support SDFG positional arguments (not only keyword arguments)
  • Use explicit subset on source node for target write
  • Add test case for copy from one field to itself using an explicit domain subset
  • Extend test case with cond by using an expression on scalar arguments as if-statement

@edopao edopao requested a review from havogt August 8, 2024 20:43
@edopao edopao changed the title feat[next][dace]: Fix GTIR lowering to SDFG for failing tests feat[next][dace]: Fix GTIR-to-SDFG lowering for failing tests Aug 14, 2024
Copy link
Contributor

@havogt havogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@edopao edopao merged commit 6eba654 into GridTools:main Aug 16, 2024
31 checks passed
@edopao edopao deleted the dace-gtir-fixes branch August 16, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants