feat[next][dace]: GTIR-to-SDFG lowering of let-lambdas #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace-fieldview-let_lambdas
…ace-fieldview-let_lambdas
…-fieldview-neighbors
…ace-fieldview-let_lambdas
egparedes
reviewed
Jul 25, 2024
There was a problem hiding this comment.
Other than a couple of minor python style issues looks fine to me, but I think someone else should be the main reviewer of this PR (@tehrengruber ? @philip-paul-mueller ?)
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_to_sdfg.py
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_to_sdfg.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_builtin_translators.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_builtin_translators.py
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_to_sdfg.py
Outdated
Show resolved
Hide resolved
edopao
commented
Jul 26, 2024
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_builtin_translators.py
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_builtin_translators.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_to_sdfg.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_to_sdfg.py
Show resolved
Hide resolved
edopao
added a commit
that referenced
this pull request
Sep 3, 2024
…DFG) (#1601) This PR proposes an alternative design for the lowering of let-lambdas to SDFG, than the design provided in #1589. The previous PR added a separate state for the definition of let-symbols: the disadvantage of that solution is that the generated SDFG does not clearly represent the data dependency. The alternative design proposed in this PR uses a nested SDFG to represent some local symbols in the lambda scope. The lambda function is lowered inside the nested SDFG. We rely on the simplify pass to remove unnecessary nested SDFGs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds lowering of let-lambdas to DaCe SDFG.