Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci[cartesian]: env var on CSCS-CI to suppress cuda backend deprecation error #1541

Merged

Conversation

DropD
Copy link
Contributor

@DropD DropD commented May 3, 2024

Description

Suppress the deprecation error for cartesian "CUDA" backend on CSCS-CI.

The following open questions remain (should be answered for a more long-term solution):

  • Why is there a deprecation error, not a warning by default (warning seems to be the convention in GT4Py)?
  • Why did CSCS-CI not fail on feat[cartesian]: gtc cuda backend deprecation #1498, only on main after merging?
  • Why does only one test fail (test_bad_layout_warns[cuda])? Is the CUDA backend otherwise untested now?

Requirements

  • All fixes and/or new features come with corresponding tests.
  • Important design decisions have been documented in the approriate ADR inside the docs/development/ADRs/ folder.

@FlorianDeconinck
Copy link
Contributor

I should have seen this issue in my PR, I am not sure why. Apologies.

cuda backend on cartesian not being tested is not an issue, considering we established it wasn't used by anyone when we poked the main users. We keep in there for silent users, if they exists.

The error over warning, comes from the fact that cuda is now going to misbehave on new features, therefore it shouldn't be used.

@DropD DropD merged commit 8c5ab41 into GridTools:main May 3, 2024
47 checks passed
@DropD
Copy link
Contributor Author

DropD commented May 3, 2024

I should have seen this issue in my PR, I am not sure why. Apologies.

cuda backend on cartesian not being tested is not an issue, considering we established it wasn't used by anyone when we poked the main users. We keep in there for silent users, if they exists.

The error over warning, comes from the fact that cuda is now going to misbehave on new features, therefore it shouldn't be used.

I checked and the CSCS-CI did pass on your PR before merging. I don't understand why at the moment.

@DropD DropD deleted the cd21-fix-deprecated-cartesian-backend-ci branch May 3, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants