-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor[next]: move lift_mode itir test fixture into program_processor #1533
Conversation
I think with this change we can also remove a couple of TODOs and temporary workarouds: https://github.com/GridTools/gt4py/blob/main/src/gt4py/next/program_processors/codegens/gtfn/gtfn_module.py https://github.com/GridTools/gt4py/blob/main/src/gt4py/next/program_processors/runners/dace_iterator/workflow.py |
Thank you! Is this
|
No, this comment is not true anymore. It can be removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just small things. Since LiftMode.SIMPLE_HEURISTIC
is not tested anymore I would add either a comment to the heuristic or remove it.
Currently we have a mix of specifying the backend which already comes with a lift_mode default and separately the lift_mode fixture in some tests. The default was not overwritten in the roundtrip backend. Now we remove the separate
lift_mode
and add extra backends with the lift_mode set.Note: we don't run double_roundtrip with temporaries and we don't use the lift_mode==SIMPLE_HEURISTIC in roundtrip, only
USE_TEMPORARIES
.Longer term we should refactor all itir tests to use the ffront test infrastructure.