Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add ruff to the automated requirement generation workflow #1497

Merged
merged 1 commit into from
Mar 25, 2024
Merged

build: add ruff to the automated requirement generation workflow #1497

merged 1 commit into from
Mar 25, 2024

Conversation

egparedes
Copy link
Contributor

@egparedes egparedes commented Mar 15, 2024 •
edited
Loading

Add cog snippet to precommit-config to grab ruff version from constraints file as usual.

havogt
havogt approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@havogt havogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe need to merge with main again to fix formatting in the latest changes.

@egparedes egparedes force-pushed the update-ruff branch 2 times, most recently from 90c238a to b90845d Compare March 20, 2024 13:42
@egparedes egparedes changed the title Update ruff build: add ruff to the automated requirement generation workflow Mar 22, 2024
@egparedes egparedes marked this pull request as ready for review March 22, 2024 13:09
@egparedes egparedes merged commit 759a241 into GridTools:main Mar 25, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@havogt havogt havogt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egparedes @havogt