Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat[next][dace]: Add gt4py workflow for the DaCe backend #1477

Merged
merged 3 commits into from
Mar 4, 2024
Merged

feat[next][dace]: Add gt4py workflow for the DaCe backend #1477

merged 3 commits into from
Mar 4, 2024

Conversation

edopao
Copy link
Contributor

@edopao edopao commented Feb 29, 2024 •
edited
Loading

Integrate the DaCe backend with the workflow API.
Still keeping the old backend interface for backwards-compatibility with icon4py. The old interface will be removed later.

@edopao edopao marked this pull request as ready for review March 1, 2024 10:51
@edopao edopao requested a review from DropD March 1, 2024 10:51
DropD
DropD requested changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@DropD DropD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall almost ready, just some minor things.

src/gt4py/next/otf/languages.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/runners/dace_iterator/workflow.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/runners/dace.py Outdated Show resolved Hide resolved
@edopao edopao requested a review from DropD March 1, 2024 17:41
@edopao edopao merged commit 628a33b into GridTools:main Mar 4, 2024
31 checks passed
@edopao edopao deleted the dace-workflow branch March 4, 2024 09:35
@edopao edopao mentioned this pull request Mar 4, 2024
Merged
edopao added a commit that referenced this pull request Mar 4, 2024
@edopao
fix[next][dace]: accept runtime lift_mode as argument to dace backend (…
02a4839 
…#1481)

Fix previous PR #1477. Like for gtfn backend, we still need to accept
the runtime `lift_mode` passed as keyword argument to the backend.
@edopao edopao mentioned this pull request Mar 20, 2024
Merged
edopao added a commit that referenced this pull request Mar 22, 2024
@edopao
feat[next][dace]: Remove old dace backend (replaced by workflow infra…
618e9cf 
…structure) (#1503)

PR #1477 added the dace backend based on workflow infrastructure. The
old backend was kept for legacy compatibility in icon4py. Now that
icon4py has switched to the new backend, we can safely remove the old
one in gt4py.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DropD DropD DropD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edopao @DropD