refactor[next]: Refactor workflow based executors and move the backend class. #1470
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed
OTFCompileExecutor
andCachedOTFCompileExecutor
merged intoModularExecutor
Moved
OTFBackend
moved and renamed tonext.backend.Backend
Reasoning
The two
*CompileExecutor
classes were identical, except for type hints. Since they are now almost exclusively used insideOTFBackend
, which does not retain typing information about which of them it contains, this distinction is no longer helpful for static type checking.OTFBackend
has always been more general than it's naming and location suggested. It is the de-facto definition of a backend withingt4py.next
: a wrapper around an executor and an allocator. This change makes the status quo visible.Requirements