Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L2RPNSandBoxReward crashes #67

Closed
Tezirg opened this issue May 5, 2020 · 2 comments
Closed

L2RPNSandBoxReward crashes #67

Tezirg opened this issue May 5, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@Tezirg
Copy link
Contributor

Tezirg commented May 5, 2020

In 0.8.0, using the grid2op.Reward.L2RPNSandBoxReward causes the framework to fail with:

python3.6/site-packages/grid2op/Reward/L2RPNSandBoxScore.py", line 35, in __call__
    p_t = np.max(env.gen_cost_per_MW[env.gen_activeprod_t > 0.], dtype=dt_float)
  File "<__array_function__ internals>", line 4, in amax
TypeError: _amax_dispatcher() got an unexpected keyword argument 'dtype'

Should remove dtype from np.max call and add a unit tests that call rewards instances to prevent this from happening
@Tezirg Tezirg added the bug Something isn't working label May 5, 2020
@Tezirg
Copy link
Contributor Author

Tezirg commented May 5, 2020

Additionnaly, dataset rte_case14_sandbox may use the L2RPNSandBoxReward as default in it's config.py

BDonnot referenced this issue in BDonnot/Grid2Op May 5, 2020
@BDonnot
making sure issue #67 is fixed
c7595e6
@BDonnot BDonnot mentioned this issue May 6, 2020
Merged
@BDonnot
Copy link
Collaborator

BDonnot commented May 6, 2020

Fixed in version v0.8.1

@BDonnot BDonnot closed this as completed May 6, 2020
BDonnot added a commit that referenced this issue Jun 24, 2020
@BDonnot
Merge pull request #67 from BDonnot/zrg-1.0.0
0394a64 
MultiMixEnvironment Iterable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BDonnot @Tezirg