Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccuracy in documentation about Observation #158

Closed
AlexTo opened this issue Oct 26, 2020 · 3 comments
Closed

Inaccuracy in documentation about Observation #158

AlexTo opened this issue Oct 26, 2020 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@AlexTo
Copy link

AlexTo commented Oct 26, 2020

This link mentions that month is 0-based indexing but looks like it is not because according to the following code, April is 4, not 3 ?

image

Please confirm other attributes as well such as day_of_week

@AlexTo AlexTo added the documentation Improvements or additions to documentation label Oct 26, 2020
@BDonnot
Copy link
Collaborator

BDonnot commented Nov 13, 2020

Hello,

The dates and times, and all the other calendar data are computed with the associated attributes of the "datatime.datetime" object.

So indeed it's labelled to be "human friendly":

  • month are between 1 and 12
  • days are between 1 and 31 (max depends on the month)
  • hour_of_day is between 0 and 23
  • minute_of_hour is between 0 and 59
  • day_of_week is between 0 and 6

Can you point me out were you spotted this mistake ? I don't see it on the documentation.

@AlexTo
Copy link
Author

AlexTo commented Nov 13, 2020

Hi Benjamin

In the link from my previous post, it says "January = 0"

image

@BDonnot
Copy link
Collaborator

BDonnot commented Dec 10, 2020

I fixed that, the documentation should be pushed in the next few minutes.

Thanks for noticing

@BDonnot BDonnot closed this as completed Dec 10, 2020
BDonnot added a commit that referenced this issue Jun 1, 2022
Adressing another grid2op issue: curtailment limit was not clear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants