Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve consistency between mixes in multi_mix #157

Open
BDonnot opened this issue Oct 23, 2020 · 1 comment
Open

Improve consistency between mixes in multi_mix #157

BDonnot opened this issue Oct 23, 2020 · 1 comment
Labels
enhancement New feature or request version 2.0 Will be made available in version 2.0 at best

Comments

@BDonnot
Copy link
Collaborator

BDonnot commented Oct 23, 2020

Is your feature request related to a problem? Please describe.

Some function with the MultimixEnv have an unexpected behavior and only affect some mixes in the environment (instead of being properly forwarded to all mixes)

This could be avoided at the creation of the first environment if some things, such as:

  • the reward helper
  • the action_space
  • the observation_space
  • Something else?
    Would be reused for all mixes.

Describe the solution you'd like

A clear and concise description of what you want to happen.
The solution would be, when à multi mix is created, to reuse the attributes from the first environnement in the other mix.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

An alternative is to loop through every mix to initialize things, like this for example:

for mix in multi_mix:
   cr = mix.get_reward_instance()
   cr.addReward(...)
  ...
@BDonnot BDonnot added the enhancement New feature or request label Oct 23, 2020
@BDonnot
Copy link
Collaborator Author

BDonnot commented Sep 9, 2021

More generally, it would even be better to have the "MultiMix" as a type of "Chronics" and NOT as a type of environment, and thus get rid of the all the "MultiMixEnv" specificities and overloading.

@BDonnot BDonnot added the version 2.0 Will be made available in version 2.0 at best label Jan 18, 2022
BDonnot added a commit that referenced this issue May 25, 2022
Propagate backend kwargs in runner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request version 2.0 Will be made available in version 2.0 at best
Projects
None yet
Development

No branches or pull requests

1 participant