feat: use cache kv manager for SchemaMetadataManager #5053

v0y4g3r · 2024-11-26T09:14:27Z

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Add cache layer for SchemaMetadataManager

Checklist

I have written the necessary rustdoc comments.
I have added the necessary unit tests and integration tests.
This PR requires documentation updates.

…'s heartbeat task • Implement InvalidateSchemaCacheHandler in heartbeat.rs to handle cache invalidation instructions. • Update HeartbeatTask constructor to accept cached_kv_backend and pass it to InvalidateSchemaCacheHandler. • Modify DatanodeBuilder to clone cached_kv_backend when creating schema_metadata_manager. • Refactor MetasrvCacheInvalidator in cache_invalidator.rs to reuse MailboxMessage for broadcasting to different channels.

coderabbitai · 2024-11-26T09:14:34Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

MichaelScofield

Lack of prefetching the database ttl option, are you gonna do it in next PR?

WenyXu

Rest LGTM

src/datanode/src/heartbeat.rs

codecov · 2024-11-26T09:39:36Z

Codecov Report

Attention: Patch coverage is 86.30137% with 20 lines in your changes missing coverage. Please review.

Project coverage is 83.77%. Comparing base (57f31d1) to head (c8c1dca).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5053      +/-   ##
==========================================
- Coverage   83.93%   83.77%   -0.17%     
==========================================
  Files        1155     1156       +1     
  Lines      216134   216244     +110     
==========================================
- Hits       181418   181156     -262     
- Misses      34716    35088     +372

…arate module • Extracted InvalidateSchemaCacheHandler and associated tests into a new file cache_invalidator.rs • Removed async_trait and CacheInvalidator related code from heartbeat.rs • Added cache_invalidator module declaration in handler.rs

v0y4g3r · 2024-11-26T10:42:18Z

Lack of prefetching the database ttl option, are you gonna do it in next PR?

Here: https://github.com/GreptimeTeam/greptimedb/pull/5053/files#diff-c8c39874ac506c24bf14a603286e832fd039cdc068f8abec26d8e4061c255f32R64-R66

src/catalog/src/kvbackend/client.rs

Standardize TODO comment format in CachedKvBackend txn method

src/datanode/src/heartbeat/handler/cache_invalidator.rs

MichaelScofield · 2024-11-26T11:05:36Z

Lack of prefetching the database ttl option, are you gonna do it in next PR?

Here: https://github.com/GreptimeTeam/greptimedb/pull/5053/files#diff-c8c39874ac506c24bf14a603286e832fd039cdc068f8abec26d8e4061c255f32R64-R66

@v0y4g3r do we need to prefetch the database options when opening the region in the datanode?

v0y4g3r · 2024-11-26T11:18:12Z

Lack of prefetching the database ttl option, are you gonna do it in next PR?

Here: https://github.com/GreptimeTeam/greptimedb/pull/5053/files#diff-c8c39874ac506c24bf14a603286e832fd039cdc068f8abec26d8e4061c255f32R64-R66

@v0y4g3r do we need to prefetch the database options when opening the region in the datanode?

I think it's ok for the first time?

MichaelScofield · 2024-11-26T11:21:50Z

Lack of prefetching the database ttl option, are you gonna do it in next PR?

Here: https://github.com/GreptimeTeam/greptimedb/pull/5053/files#diff-c8c39874ac506c24bf14a603286e832fd039cdc068f8abec26d8e4061c255f32R64-R66

@v0y4g3r do we need to prefetch the database options when opening the region in the datanode?

I think it's ok for the first time?

@v0y4g3r hmm... just some picky ones would complain about the first time performance. But let's not block this PR, I'll do it.

src/datanode/src/heartbeat/handler/cache_invalidator.rs

* feat: add cache for schema options * fix/use-cache-kv-manager: Add cache invalidation handling to Datanode's heartbeat task • Implement InvalidateSchemaCacheHandler in heartbeat.rs to handle cache invalidation instructions. • Update HeartbeatTask constructor to accept cached_kv_backend and pass it to InvalidateSchemaCacheHandler. • Modify DatanodeBuilder to clone cached_kv_backend when creating schema_metadata_manager. • Refactor MetasrvCacheInvalidator in cache_invalidator.rs to reuse MailboxMessage for broadcasting to different channels. * fix: only remove schema related cache entries * chore: add more tests * fix/use-cache-kv-manager: Moved InvalidateSchemaCacheHandler to a separate module • Extracted InvalidateSchemaCacheHandler and associated tests into a new file cache_invalidator.rs • Removed async_trait and CacheInvalidator related code from heartbeat.rs • Added cache_invalidator module declaration in handler.rs * fix: unit tests * fix/use-cache-kv-manager: Standardize TODO comment format in CachedKvBackend txn method * Update src/datanode/src/heartbeat/handler/cache_invalidator.rs * Update src/datanode/src/heartbeat/handler/cache_invalidator.rs * Update src/datanode/src/heartbeat/handler/cache_invalidator.rs --------- Co-authored-by: jeremyhi <[email protected]>

v0y4g3r added 3 commits November 26, 2024 00:22

feat: add cache for schema options

58791ad

fix: only remove schema related cache entries

f2466f2

v0y4g3r requested review from MichaelScofield and a team as code owners November 26, 2024 09:14

github-actions bot added the docs-not-required This change does not impact docs. label Nov 26, 2024

v0y4g3r requested a review from WenyXu November 26, 2024 09:17

MichaelScofield approved these changes Nov 26, 2024

View reviewed changes

WenyXu approved these changes Nov 26, 2024

View reviewed changes

src/datanode/src/heartbeat.rs Outdated Show resolved Hide resolved

WenyXu requested a review from fengjiachun November 26, 2024 09:37

v0y4g3r added 3 commits November 26, 2024 01:46

chore: add more tests

7ac1c28

fix: unit tests

f25fbad

v0y4g3r force-pushed the fix/use-cache-kv-manager branch from e576fd2 to f25fbad Compare November 26, 2024 10:41

fengjiachun reviewed Nov 26, 2024

View reviewed changes

src/catalog/src/kvbackend/client.rs Outdated Show resolved Hide resolved

fix/use-cache-kv-manager:

2803a7f

Standardize TODO comment format in CachedKvBackend txn method

fengjiachun approved these changes Nov 26, 2024

View reviewed changes

fengjiachun enabled auto-merge November 26, 2024 11:03

MichaelScofield reviewed Nov 26, 2024

View reviewed changes

src/datanode/src/heartbeat/handler/cache_invalidator.rs Outdated Show resolved Hide resolved

fengjiachun added this pull request to the merge queue Nov 26, 2024

fengjiachun removed this pull request from the merge queue due to a manual request Nov 26, 2024

fengjiachun reviewed Nov 26, 2024

View reviewed changes

src/datanode/src/heartbeat/handler/cache_invalidator.rs Outdated Show resolved Hide resolved

src/datanode/src/heartbeat/handler/cache_invalidator.rs Outdated Show resolved Hide resolved

fengjiachun added 2 commits November 26, 2024 19:38

Update src/datanode/src/heartbeat/handler/cache_invalidator.rs

49e5b24

Update src/datanode/src/heartbeat/handler/cache_invalidator.rs

f30cac9

fengjiachun reviewed Nov 26, 2024

View reviewed changes

src/datanode/src/heartbeat/handler/cache_invalidator.rs Outdated Show resolved Hide resolved

Update src/datanode/src/heartbeat/handler/cache_invalidator.rs

c8c1dca

zhongzc mentioned this pull request Nov 26, 2024

Release v0.10.2 #5055

Closed

1 task

fengjiachun added this pull request to the merge queue Nov 26, 2024

Merged via the queue into GreptimeTeam:main with commit a617e0d Nov 26, 2024
35 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: use cache kv manager for SchemaMetadataManager #5053

feat: use cache kv manager for SchemaMetadataManager #5053

v0y4g3r commented Nov 26, 2024 •

edited

Loading

coderabbitai bot commented Nov 26, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

MichaelScofield left a comment

WenyXu left a comment

codecov bot commented Nov 26, 2024 •

edited

Loading

v0y4g3r commented Nov 26, 2024

MichaelScofield commented Nov 26, 2024

v0y4g3r commented Nov 26, 2024

MichaelScofield commented Nov 26, 2024

feat: use cache kv manager for SchemaMetadataManager #5053

feat: use cache kv manager for SchemaMetadataManager #5053

Conversation

v0y4g3r commented Nov 26, 2024 • edited Loading

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Checklist

coderabbitai bot commented Nov 26, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

MichaelScofield left a comment

Choose a reason for hiding this comment

WenyXu left a comment

Choose a reason for hiding this comment

codecov bot commented Nov 26, 2024 • edited Loading

Codecov Report

v0y4g3r commented Nov 26, 2024

MichaelScofield commented Nov 26, 2024

v0y4g3r commented Nov 26, 2024

MichaelScofield commented Nov 26, 2024

v0y4g3r commented Nov 26, 2024 •

edited

Loading

codecov bot commented Nov 26, 2024 •

edited

Loading