feat(remote wal): set default compresion to LZ4

[WenyXu]

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Switch the default compression algorithm to LZ4 to reduce WAL size

	RaftEngine	Kafka, NoCompression	Kafka, LZ4
WAL Size	14GiB	38GiB	15GiB
Replay (mean)	57s	53s	54s
Insertion	970-980k point/s	960-970k point/s	960-970k point/s

Checklist

• I have written the necessary rustdoc comments.
• I have added the necessary unit tests and integration tests.
• This PR requires documentation updates.

Summary by CodeRabbit

• New Features

  • Updated compression method from NoCompression to Lz4 across all configurations for improved data handling efficiency.

• Improvements

  • Enhanced data compression in TopicManager and various configuration settings, leading to better performance and reduced storage requirements.

[coderabbitai]

Walkthrough

The recent changes focus primarily on updating the compression method used throughout the codebase. Specifically, the compression mode switched from NoCompression to Lz4 in various configurations and the TopicManager implementation. This update should improve data storage efficiency and potentially enhance performance.

Changes

Files	Change Summary
src/common/meta/src/wal_options_allocator/kafka/topic_manager.rs	Changed compression method from NoCompression to Lz4 in TopicManager.
src/common/wal/src/config.rs	Updated compression setting to Compression::Lz4 for DatanodeWalConfig and DatanodeKafkaConfig.
src/common/wal/src/config/kafka/datanode.rs	Modified compression setting in DatanodeKafkaConfig from NoCompression to Lz4.
src/common/wal/src/config/kafka/standalone.rs	Changed compression setting in StandaloneKafkaConfig from NoCompression to Lz4.

Poem

In the rustling code where bytes align,
Lz4 now compresses, oh so fine.
From NoCompression we take a flight,
Data packed smaller, faster than light.
A hop, skip, and a leap so grand,
Our configurations stand hand in hand.
🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f71b7b9 and 13f71f3.

Files selected for processing (4)

• src/common/meta/src/wal_options_allocator/kafka/topic_manager.rs (1 hunks)
• src/common/wal/src/config.rs (2 hunks)
• src/common/wal/src/config/kafka/datanode.rs (1 hunks)
• src/common/wal/src/config/kafka/standalone.rs (1 hunks)

Additional comments not posted (5)

src/common/wal/src/config/kafka/datanode.rs (1)

49-49: LGTM! Ensure the compression setting is consistently applied.

The default compression algorithm has been updated to LZ4 as intended.

src/common/wal/src/config/kafka/standalone.rs (1)

70-70: LGTM! Ensure the compression setting is consistently applied.

The default compression algorithm has been updated to LZ4 as intended.

src/common/wal/src/config.rs (2)

210-210: LGTM! Ensure the compression setting is consistently applied.

The compression algorithm has been updated to LZ4 in the DatanodeKafkaConfig struct as intended.

---

232-232: LGTM! Ensure the compression setting is consistently applied.

The compression algorithm has been updated to LZ4 in the StandaloneKafkaConfig struct as intended.

src/common/meta/src/wal_options_allocator/kafka/topic_manager.rs (1)

176-176: LGTM! Ensure the compression setting is consistently applied.

The compression algorithm has been updated to LZ4 in the try_append_noop_record method as intended.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.01%. Comparing base (849e0b9) to head (13f71f3).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4294      +/-   ##
==========================================
- Coverage   85.31%   85.01%   -0.30%     
==========================================
  Files        1063     1066       +3     
  Lines      188345   188636     +291     
==========================================
- Hits       160686   160372     -314     
- Misses      27659    28264     +605     

[killme2008]

LGTM