-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fuzz): generate valid string #4281
Conversation
WalkthroughThe recent changes involve importing a new Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- tests-fuzz/src/ir.rs (2 hunks)
Additional comments not posted (2)
tests-fuzz/src/ir.rs (2)
43-43
: The new import statement forWordGenerator
looks good.The addition of
WordGenerator
is appropriate for generating valid strings.
454-458
: The changes topartible_column_options_generator
are correct.Passing
Some(&WordGenerator)
togenerate_random_value
ensures valid strings are generated for the column default value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- tests-fuzz/src/utils/migration.rs (1 hunks)
- tests-fuzz/targets/migration/fuzz_migrate_mito_regions.rs (1 hunks)
Files skipped from review due to trivial changes (2)
- tests-fuzz/src/utils/migration.rs
- tests-fuzz/targets/migration/fuzz_migrate_mito_regions.rs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4281 +/- ##
==========================================
- Coverage 84.96% 84.69% -0.27%
==========================================
Files 1058 1058
Lines 188055 188059 +4
==========================================
- Hits 159780 159284 -496
- Misses 28275 28775 +500 |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Generate valid string for column default value
Checklist
Summary by CodeRabbit
WordGenerator
.