-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: region logical regions after catching up #4176
Conversation
efdb6a8
to
24f2f2e
Compare
24f2f2e
to
e986c0c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4176 +/- ##
==========================================
- Coverage 85.12% 84.86% -0.27%
==========================================
Files 1022 1022
Lines 179843 179859 +16
==========================================
- Hits 153094 152631 -463
- Misses 26749 27228 +479 |
@WenyXu Please describe the PR in detail. What issue does it address? What happened before this patch etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This PR registers metric logical regions after invoking catchup and fixes metric logical regions not found issues after migrating a physical region.
After replaying the WAL of a metric metadata region, there are two places required to register logical regions manually:
Checklist