-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update default size of bgworkers, add hbworkers #4129
feat: update default size of bgworkers, add hbworkers #4129
Conversation
It seems we need to update sample configuration as well. But I just need to make sure this looks good to you before moving on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a workaround. We might need to implement some other approaches to limit the resources used by background tasks.
There is an issue related to the config test: #4126 Options related to the number of cores and the host memory are unstable in tests. You might encounter the same problem. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4129 +/- ##
==========================================
- Coverage 85.40% 84.60% -0.80%
==========================================
Files 994 1022 +28
Lines 174087 179017 +4930
==========================================
+ Hits 148677 151466 +2789
- Misses 25410 27551 +2141 |
Just updated defaults and sample configuration. PTAL @evenyag @MichaelScofield |
@sunng87 I realize that we don't need to make the size of the heartbeat runtime configurable. If sending the heartbeat occupies one core for the whole time, there must be something wrong...... I'd suggest not exposing |
@evenyag Sounds good. We need to keep to UI as minimal as possible. We only expose it when there is a real case. |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#4128
What's changed and what's your intention?
This patch changes default bg_worker runtime to half of cpu_num, to avoid cpu-intensive tasks to fill up all compute resources
It also use dedicated runtime to host heartbeat tasks, which is of higher priority.
Checklist