-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove double checks of memtable size #4117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4117 +/- ##
==========================================
- Coverage 85.40% 85.10% -0.30%
==========================================
Files 994 994
Lines 174093 173988 -105
==========================================
- Hits 148682 148073 -609
- Misses 25411 25915 +504 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: dennis zhuang <[email protected]>
Thank you. |
I hereby agree to the terms of the GreptimeDB CLA.
What's changed and what's your intention?
In the
freeze_mutable
function, the methodmemtables.mutable.is_empty()
is checked twice - once inVersionControl::freeze_mutable
and again inMemtableVersion::freeze_mutable
. These check could be combined so theunwrap
can be eliminated.Checklist