-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement drop multiple tables #4085
Conversation
Would you like to add some sqlness tests in greptimedb/tests/cases/standalone/common/drop/drop_table.sql Lines 1 to 13 in 45fee94
Including the cases of success, partial success, and failure |
The Rustfmt and Clippy checks are failed, run |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4085 +/- ##
==========================================
- Coverage 85.44% 85.14% -0.30%
==========================================
Files 992 992
Lines 173377 173412 +35
==========================================
- Hits 148141 147652 -489
- Misses 25236 25760 +524 |
We are still trying to fix it #4081 |
Hi @sarailQAQ let’s rebase this PR, the CI should be fixed |
Co-authored-by: Weny Xu <[email protected]>
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
close #4020
What's changed and what's your intention?
Implemet dropping multiple tables in the single statement.
If any tables do not exist without IF EXISTS, the statement fails with an error and don`t make any change, referencing MySQL.
It works for SQL requests, not ready for gRPC.
Checklist